Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1806523002: Add BUILD.gn rules to compile third_party/class-dump. (Closed)

Created:
4 years, 9 months ago by sdefresne
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@compiler
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add BUILD.gn rules to compile third_party/class-dump. Add third_party/class-dump/BUILD.gn to build class-dump as a host tool as part of the iOS build. Create a template "class_dump" (in third_party/class-dump/class-dump.gni) to simplify the execution of the class-dump tool on given framework. This required converting testing/iossim/redirect-stdout.sh to a python script as gn can only invokes python script. TBR=rohitrao@chromium.org BUG=594519 Committed: https://crrev.com/6b121e47561bb4dd582adff12146655645368639 Cr-Commit-Position: refs/heads/master@{#381687}

Patch Set 1 #

Patch Set 2 : Add missing comma to fix compilation with gyp #

Patch Set 3 : Remove use of //build/config/mac:macosx_version_min_10_9 #

Patch Set 4 : Use ${host_toolchain} instead of //build/toolchain/mac:clang_x64 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+387 lines, -60 lines) Patch
M testing/iossim/iossim.gyp View 1 2 chunks +38 lines, -35 lines 0 comments Download
D testing/iossim/redirect-stdout.sh View 1 chunk +0 lines, -25 lines 0 comments Download
A third_party/class-dump/BUILD.gn View 1 2 1 chunk +197 lines, -0 lines 0 comments Download
A third_party/class-dump/class-dump.gni View 1 2 3 1 chunk +96 lines, -0 lines 0 comments Download
M third_party/class-dump/class-dump.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/class-dump/class-dump.py View 1 chunk +55 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
sdefresne
dpranke: Please take a look. rohitrao: OWNERS approval.
4 years, 9 months ago (2016-03-15 14:03:38 UTC) #2
Dirk Pranke
lgtm
4 years, 9 months ago (2016-03-16 01:25:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806523002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806523002/60001
4 years, 9 months ago (2016-03-17 10:41:15 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-17 10:45:53 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 10:47:22 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6b121e47561bb4dd582adff12146655645368639
Cr-Commit-Position: refs/heads/master@{#381687}

Powered by Google App Engine
This is Rietveld 408576698