Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issue 1796093003: Remove support for old version of Xcode from iossim. (Closed)

Created:
4 years, 9 months ago by sdefresne
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove support for old version of Xcode from iossim. All bots and developers are now using Xcode 7.0 or more recent to build iOS so remove support for version of Xcode older than 6.0 from iossim. TBR=rohitrao@chromium.org BUG=594519 Committed: https://crrev.com/3825f0fad8cd30b8c0748101620d74ac512d4bb6 Cr-Commit-Position: refs/heads/master@{#381428}

Patch Set 1 #

Patch Set 2 : Rebase on origin/master #

Patch Set 3 : Rebase on origin/master and remove unused const variables #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -270 lines) Patch
M testing/iossim/iossim.gyp View 2 chunks +43 lines, -62 lines 0 comments Download
M testing/iossim/iossim.mm View 1 2 15 chunks +71 lines, -208 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
sdefresne
justincohen: can you do first pass review? rohitrao: need your OWNERS stamp once justin has ...
4 years, 9 months ago (2016-03-14 11:51:17 UTC) #2
justincohen
Are you sure all the bots are on Xcode 7?
4 years, 9 months ago (2016-03-14 16:10:11 UTC) #3
sdefresne
On 2016/03/14 at 16:10:11, justincohen wrote: > Are you sure all the bots are on ...
4 years, 9 months ago (2016-03-15 09:10:43 UTC) #4
sdefresne
On 2016/03/15 at 09:10:43, sdefresne wrote: > On 2016/03/14 at 16:10:11, justincohen wrote: > > ...
4 years, 9 months ago (2016-03-15 09:11:19 UTC) #5
justincohen
lgtm
4 years, 9 months ago (2016-03-15 16:16:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1796093003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1796093003/40001
4 years, 9 months ago (2016-03-16 10:17:01 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-16 10:50:21 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 10:51:21 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3825f0fad8cd30b8c0748101620d74ac512d4bb6
Cr-Commit-Position: refs/heads/master@{#381428}

Powered by Google App Engine
This is Rietveld 408576698