Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 179403010: Revert of Let DM run unit tests. (Closed)

Created:
6 years, 10 months ago by reed1
Modified:
6 years, 10 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Let DM run unit tests. (https://codereview.chromium.org/178273002/) Reason for revert: broke tests Original issue's description: > Let DM run unit tests. > - refactor GYPs and a few flags > - make GPU tests grab a thread-local GrContextFactory when needed as we do in DM for GMs > - add a few more UI features to make DM more like tests > > I believe this makes the program 'tests' obsolete. > > It should be somewhat faster to run the two sets together than running the old binaries serially: > - serial: tests 20s (3m18s CPU), dm 21s (3m01s CPU) > - together: 27s (6m21s CPU) > > Next up is to incorporate benches. I'm only planning there on a single-pass sanity check, so that won't obsolete the program 'bench' just yet. > > Tested: out/Debug/tests && out/Debug/dm && echo ok > BUG=skia: > > Committed: http://code.google.com/p/skia/source/detail?r=13586 TBR=bsalomon@google.com,mtklein@google.com,tfarina@chromium.org,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13587

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -430 lines) Patch
M dm/DM.cpp View 5 chunks +32 lines, -64 lines 0 comments Download
M dm/DMGpuTask.h View 1 chunk +0 lines, -1 line 0 comments Download
M dm/DMGpuTask.cpp View 2 chunks +15 lines, -4 lines 0 comments Download
M dm/DMReporter.h View 2 chunks +5 lines, -2 lines 0 comments Download
M dm/DMReporter.cpp View 2 chunks +5 lines, -11 lines 0 comments Download
M dm/DMTask.h View 1 chunk +1 line, -1 line 0 comments Download
M dm/DMTask.cpp View 2 chunks +4 lines, -7 lines 0 comments Download
M dm/DMTaskRunner.h View 2 chunks +4 lines, -8 lines 0 comments Download
M dm/DMTaskRunner.cpp View 2 chunks +3 lines, -25 lines 0 comments Download
D dm/DMTestTask.h View 1 chunk +0 lines, -50 lines 0 comments Download
D dm/DMTestTask.cpp View 1 chunk +0 lines, -34 lines 0 comments Download
M gyp/dm.gyp View 3 chunks +1 line, -7 lines 0 comments Download
M gyp/tests.gyp View 1 chunk +176 lines, -1 line 0 comments Download
D gyp/tests.gypi View 1 chunk +0 lines, -180 lines 0 comments Download
M tests/Test.h View 3 chunks +4 lines, -10 lines 0 comments Download
M tests/Test.cpp View 3 chunks +17 lines, -12 lines 0 comments Download
M tests/skia_test.cpp View 8 chunks +19 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
reed1
Created Revert of Let DM run unit tests.
6 years, 10 months ago (2014-02-25 20:01:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/179403010/1
6 years, 10 months ago (2014-02-25 20:01:58 UTC) #2
commit-bot: I haz the power
6 years, 10 months ago (2014-02-25 20:02:17 UTC) #3
Message was sent while issue was closed.
Change committed as 13587

Powered by Google App Engine
This is Rietveld 408576698