Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1382)

Unified Diff: dm/DMReporter.cpp

Issue 179403010: Revert of Let DM run unit tests. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dm/DMReporter.h ('k') | dm/DMTask.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dm/DMReporter.cpp
diff --git a/dm/DMReporter.cpp b/dm/DMReporter.cpp
index 1ff64c57cc5f56ded6207d0de5dcdfc27219b683..0fd83e5bb656a1406cd6842a55185a4df8b96f45 100644
--- a/dm/DMReporter.cpp
+++ b/dm/DMReporter.cpp
@@ -3,27 +3,21 @@
#include "SkCommandLineFlags.h"
#include "OverwriteLine.h"
-DEFINE_bool2(quiet, q, false, "If true, don't print status updates.");
-DEFINE_bool2(verbose, v, false, "If true, print status updates one-per-line.");
+DEFINE_bool(quiet, false, "If true, don't print status updates.");
namespace DM {
-void Reporter::finish(SkString name) {
- sk_atomic_inc(&fFinished);
-
+void Reporter::updateStatusLine() const {
if (FLAGS_quiet) {
return;
}
SkString status;
- status.printf("%s%d tasks left",
- FLAGS_verbose ? "\n" : kSkOverwriteLine,
- this->started() - this->finished());
+ status.printf("%s%d tasks left", kSkOverwriteLine, this->started() - this->finished());
const int failed = this->failed();
if (failed > 0) {
status.appendf(", %d failed", failed);
}
- status.appendf("\t[%s done]", name.c_str());
SkDebugf(status.c_str());
}
@@ -32,9 +26,9 @@
return fFailures.count();
}
-void Reporter::fail(SkString msg) {
+void Reporter::fail(SkString name) {
SkAutoMutexAcquire writer(&fMutex);
- fFailures.push_back(msg);
+ fFailures.push_back(name);
}
void Reporter::getFailures(SkTArray<SkString>* failures) const {
« no previous file with comments | « dm/DMReporter.h ('k') | dm/DMTask.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698