dm/DMTask.cpp - Issue 179403010: Revert of Let DM run unit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dm/DMTask.cpp

Issue 179403010: Revert of Let DM run unit tests. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: dm/DMTask.cpp

diff --git a/dm/DMTask.cpp b/dm/DMTask.cpp

index 2f009f067028532e9fbf954164d9c489726feb97..a5c75f0f8a5d10f99fcb5de6518a375e77e73d9b 100644

--- a/dm/DMTask.cpp

+++ b/dm/DMTask.cpp

@@ -26,7 +26,8 @@

if (!this->shouldSkip()) {

this->draw();

}

- fReporter->finish(this->name());

+ fReporter->finish();

+ fReporter->updateStatusLine();

delete this;

}

@@ -38,12 +39,8 @@

}

-void Task::fail(const char* msg) {

- SkString failure(this->name());

- if (msg) {

- failure.appendf(": %s", msg);

- }

- fReporter->fail(failure);

+void Task::fail() {

+ fReporter->fail(this->name());

}

} // namespace DM

« no previous file with comments | « dm/DMTask.h ('k') | dm/DMTaskRunner.h » ('j') | no next file with comments »