Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Side by Side Diff: scripts/slave/recipes/flutter/engine.py

Issue 1788653004: Fix bot_update api rename. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Long line. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « scripts/slave/recipe_modules/v8/api.py ('k') | scripts/slave/recipes/swarming/staging.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import contextlib 5 import contextlib
6 6
7 DEPS = [ 7 DEPS = [
8 'depot_tools/bot_update', 8 'depot_tools/bot_update',
9 'depot_tools/gclient', 9 'depot_tools/gclient',
10 'file', 10 'file',
11 'gsutil', 11 'gsutil',
12 'recipe_engine/path', 12 'recipe_engine/path',
13 'recipe_engine/platform', 13 'recipe_engine/platform',
14 'recipe_engine/properties', 14 'recipe_engine/properties',
15 'recipe_engine/step', 15 'recipe_engine/step',
16 'zip', 16 'zip',
17 ] 17 ]
18 18
19 BUCKET_NAME = 'flutter_infra' 19 BUCKET_NAME = 'flutter_infra'
20 20
21 def GetCloudPath(api, path): 21 def GetCloudPath(api, path):
22 # TODO(eseidel): api.bot_update.properties is supposedly a known api wart. 22 # TODO(eseidel): api.bot_update.last_returned_properties is supposedly a known
23 # iannucci says it will be improved at some point. 23 # api wart. iannucci says it will be improved at some point.
24 git_hash = api.bot_update.properties['got_engine_revision'] 24 git_hash = api.bot_update.last_returned_properties['got_engine_revision']
25 return 'flutter/%s/%s' % (git_hash, path) 25 return 'flutter/%s/%s' % (git_hash, path)
26 26
27 27
28 def Build(api, config, *targets): 28 def Build(api, config, *targets):
29 checkout = api.path['checkout'] 29 checkout = api.path['checkout']
30 build_dir = checkout.join('out/%s' % config) 30 build_dir = checkout.join('out/%s' % config)
31 ninja_args = ['ninja', '-C', build_dir] 31 ninja_args = ['ninja', '-C', build_dir]
32 ninja_args.extend(targets) 32 ninja_args.extend(targets)
33 api.step('build %s' % ' '.join([config] + list(targets)), ninja_args) 33 api.step('build %s' % ' '.join([config] + list(targets)), ninja_args)
34 34
(...skipping 208 matching lines...) Expand 10 before | Expand all | Expand 10 after
243 GenerateXcodeProject(api) 243 GenerateXcodeProject(api)
244 244
245 245
246 def GenTests(api): 246 def GenTests(api):
247 # A valid commit to flutter/engine, to make the gsutil urls look real. 247 # A valid commit to flutter/engine, to make the gsutil urls look real.
248 for platform in ('mac', 'linux'): 248 for platform in ('mac', 'linux'):
249 yield (api.test(platform) + api.platform(platform, 64) 249 yield (api.test(platform) + api.platform(platform, 64)
250 + api.properties(mastername='client.flutter', 250 + api.properties(mastername='client.flutter',
251 buildername='%s Engine' % platform.capitalize(), 251 buildername='%s Engine' % platform.capitalize(),
252 slavename='fake-m1', clobber='')) 252 slavename='fake-m1', clobber=''))
OLDNEW
« no previous file with comments | « scripts/slave/recipe_modules/v8/api.py ('k') | scripts/slave/recipes/swarming/staging.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698