| OLD | NEW |
| 1 # Copyright 2013 The Chromium Authors. All rights reserved. | 1 # Copyright 2013 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 import argparse | 5 import argparse |
| 6 import datetime | 6 import datetime |
| 7 import random | 7 import random |
| 8 import re | 8 import re |
| 9 import urllib | 9 import urllib |
| 10 | 10 |
| (...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 166 patch_root=[None, 'v8'][bool(self.m.tryserver.is_tryserver)], | 166 patch_root=[None, 'v8'][bool(self.m.tryserver.is_tryserver)], |
| 167 output_manifest=True, | 167 output_manifest=True, |
| 168 with_branch_heads=needs_branch_heads, | 168 with_branch_heads=needs_branch_heads, |
| 169 patch_project_roots={'v8': []}, | 169 patch_project_roots={'v8': []}, |
| 170 **kwargs) | 170 **kwargs) |
| 171 | 171 |
| 172 assert update_step.json.output['did_run'] | 172 assert update_step.json.output['did_run'] |
| 173 | 173 |
| 174 # Bot_update maintains the properties independent of the UI | 174 # Bot_update maintains the properties independent of the UI |
| 175 # presentation. | 175 # presentation. |
| 176 self.revision = self.m.bot_update.properties['got_revision'] | 176 self.revision = self.m.bot_update.last_returned_properties['got_revision'] |
| 177 self.revision_cp = self.m.bot_update.properties['got_revision_cp'] | 177 self.revision_cp = ( |
| 178 self.m.bot_update.last_returned_properties['got_revision_cp']) |
| 178 self.revision_number = str(self.m.commit_position.parse_revision( | 179 self.revision_number = str(self.m.commit_position.parse_revision( |
| 179 self.revision_cp)) | 180 self.revision_cp)) |
| 180 | 181 |
| 181 return update_step | 182 return update_step |
| 182 | 183 |
| 183 def calculate_patch_base(self): | 184 def calculate_patch_base(self): |
| 184 """Calculates the latest commit hash that fits the patch.""" | 185 """Calculates the latest commit hash that fits the patch.""" |
| 185 url = ('https://codereview.chromium.org/download/issue%s_%s.diff' % | 186 url = ('https://codereview.chromium.org/download/issue%s_%s.diff' % |
| 186 (self.m.properties['issue'], self.m.properties['patchset'])) | 187 (self.m.properties['issue'], self.m.properties['patchset'])) |
| 187 step_result = self.m.python( | 188 step_result = self.m.python( |
| (...skipping 887 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 1075 def report_culprits(self, culprit_range): | 1076 def report_culprits(self, culprit_range): |
| 1076 assert culprit_range | 1077 assert culprit_range |
| 1077 if len(culprit_range) > 1: | 1078 if len(culprit_range) > 1: |
| 1078 text = 'Suspecting multiple commits' | 1079 text = 'Suspecting multiple commits' |
| 1079 else: | 1080 else: |
| 1080 text = 'Suspecting %s' % culprit_range[0][:8] | 1081 text = 'Suspecting %s' % culprit_range[0][:8] |
| 1081 | 1082 |
| 1082 step_result = self.m.step(text, cmd=None) | 1083 step_result = self.m.step(text, cmd=None) |
| 1083 for culprit in culprit_range: | 1084 for culprit in culprit_range: |
| 1084 step_result.presentation.links[culprit[:8]] = COMMIT_TEMPLATE % culprit | 1085 step_result.presentation.links[culprit[:8]] = COMMIT_TEMPLATE % culprit |
| OLD | NEW |