scripts/slave/recipe_modules/v8/api.py - Issue 1788653004: Fix bot_update api rename.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/v8/api.py

Issue 1788653004: Fix bot_update api rename. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Long line. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/slave/recipe_modules/v8/api.py

diff --git a/scripts/slave/recipe_modules/v8/api.py b/scripts/slave/recipe_modules/v8/api.py

index 8d792ea0301ebf36de4f05ad251f2730e9f73d94..9419f37ba1ce94c2a25b27d7241a07e1f735a7bb 100644

--- a/scripts/slave/recipe_modules/v8/api.py

+++ b/scripts/slave/recipe_modules/v8/api.py

@@ -173,8 +173,9 @@ class V8Api(recipe_api.RecipeApi):

# Bot_update maintains the properties independent of the UI

# presentation.

- self.revision = self.m.bot_update.properties['got_revision']

- self.revision_cp = self.m.bot_update.properties['got_revision_cp']

+ self.revision = self.m.bot_update.last_returned_properties['got_revision']

+ self.revision_cp = (

+ self.m.bot_update.last_returned_properties['got_revision_cp'])

self.revision_number = str(self.m.commit_position.parse_revision(

self.revision_cp))