Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Issue 178783002: Revert 252889 "Revert 252883 "Remove tests and code for showModa..." (Closed)

Created:
6 years, 10 months ago by jamesr
Modified:
6 years, 10 months ago
Reviewers:
haraken
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 252889 "Revert 252883 "Remove tests and code for showModa..." Layout test failures are expected and suppressed on the blink side. > Revert 252883 "Remove tests and code for showModalDialog" > > This CL broke show-modal-dialog tests in Blink. > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&tests=fast/dom/Window/open-window-min-size.html,fast/events/scroll-event-during-modal-dialog.html,fast/events/show-modal-dialog-onblur-onfocus.html,fast/harness/show-modal-dialog.html > > > Remove tests and code for showModalDialog > > > > This deletes the chromium-side implementation logic and a few tests for > > showModalDialog. I believe more simplification is possible to do without the > > design constraints imposed by showModalDialog but we should probably start > > small in case we run into unexpected compat issues. > > > > R=darin > > BUG=345831 > > > > Review URL: https://codereview.chromium.org/165793003 > > TBR=jamesr@chromium.org > > Review URL: https://codereview.chromium.org/177263002 TBR=haraken@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252989

Patch Set 1 #

Messages

Total messages: 2 (0 generated)
jamesr
6 years, 10 months ago (2014-02-24 21:46:55 UTC) #1
jamesr
6 years, 10 months ago (2014-02-24 21:47:29 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r252989.

Powered by Google App Engine
This is Rietveld 408576698