Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: trunk/src/chrome/browser/ui/browser_browsertest.cc

Issue 178783002: Revert 252889 "Revert 252883 "Remove tests and code for showModa..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/chrome/test/data/showmodaldialog.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/browser/ui/browser_browsertest.cc
===================================================================
--- trunk/src/chrome/browser/ui/browser_browsertest.cc (revision 252987)
+++ trunk/src/chrome/browser/ui/browser_browsertest.cc (working copy)
@@ -2018,30 +2018,6 @@
}
#endif
-class ShowModalDialogTest : public BrowserTest {
- public:
- ShowModalDialogTest() {}
-
- virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
- command_line->AppendSwitch(switches::kDisablePopupBlocking);
- }
-};
-
-IN_PROC_BROWSER_TEST_F(ShowModalDialogTest, BasicTest) {
- // This navigation should show a modal dialog that will be immediately
- // closed, but the fact that it was shown should be recorded.
- GURL url = ui_test_utils::GetTestUrl(
- base::FilePath(), base::FilePath().AppendASCII("showmodaldialog.html"));
-
- base::string16 expected_title(ASCIIToUTF16("SUCCESS"));
- content::TitleWatcher title_watcher(
- browser()->tab_strip_model()->GetActiveWebContents(), expected_title);
- ui_test_utils::NavigateToURL(browser(), url);
-
- // Verify that we set a mark on successful dialog show.
- ASSERT_EQ(expected_title, title_watcher.WaitAndGetTitle());
-}
-
IN_PROC_BROWSER_TEST_F(BrowserTest, DisallowFileUrlUniversalAccessTest) {
GURL url = ui_test_utils::GetTestUrl(
base::FilePath(),
« no previous file with comments | « no previous file | trunk/src/chrome/test/data/showmodaldialog.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698