Remove unneeded code from WebTestProxyBase.

Remove unneeded code from WebTestProxyBase.

Removed WebTestProxyBase::GetDelegate and GetInterfaces methods,
which were only used to access WebTestDelegate::PrintMessage and
WebTestInterfaces::ShouldStayOnPageAfterHandlingBeforeUnload from
4 methods of WebFrameTestProxy.  Implementing these 4 methods
inside WebTestProxyBase is more consistent with the rest of the code
- i.e. we want WebTestProxy and WebFrameTestProxy to have no logic
and always delegate to WebTestProxyBase instead.  Removing GetDelegate
and GetInterface also avoids unnecessarily exposing full breadth
of these interfaces when only a small subset is needed.

The above allowed WebTestProxyBase::removing web_test_interfaces_ field.

The above also meant that we no longer need to expose
ShouldStayOnPageAfterHandlingBeforeUnload from WebTestRunner
- exposing via TestRunner is sufficient.

Removed unused WebTestProxyBase::web_widget() accessor.
Removed unused TestInterfaces::GetProxy() accessor.

Removed Hide/MoveValidationMessage method declarations from WebTestProxyBase
- there were no definitions anywhere...

Removed BlinkTestRunner::OnWebTestProxyBaseDestroy because it had an empty body.
Consequently also removed WebTestDelegate::OnWebTestProxyBaseDestroy.

BUG=

Committed: https://crrev.com/e26c3d638b03199daccb3bf602adac2d8a4a7f75
Cr-Commit-Position: refs/heads/master@{#381110}

[Łukasz Anforowicz, 2016-03-11 23:23:20]

lukasza@chromium.org changed reviewers:
+ jochen@chromium.org

[Łukasz Anforowicz, 2016-03-11 23:23:20]

jochen@, can you please take a look?

[Łukasz Anforowicz, 2016-03-11 23:23:27]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-11 23:23:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1787743003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1787743003/1

[commit-bot: I haz the power, 2016-03-11 23:26:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 23:26:32]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Łukasz Anforowicz, 2016-03-12 00:01:28]

Description was changed from

==========
Remove unneeded code from WebTestProxyBase.

Removed WebTestProxyBase::GetDelegate and GetInterfaces methods,
which were only used to access WebTestDelegate::PrintMessage and
WebTestInterfaces::ShouldStayOnPageAfterHandlingBeforeUnload from
4 methods of WebFrameTestProxy.  Implementing these 4 methods
inside WebTestProxyBase is more consistent with the rest of the code
- i.e. we want WebTestProxy and WebFrameTestProxy to have no logic
and always delegate to WebTestProxyBase instead.  Removing GetDelegate
and GetInterface also avoids unnecessarily exposing full breadth
of these interfaces when only a small subset is needed.

The above allowed WebTestProxyBase::removing web_test_interfaces_ field.

The above also meant that we no longer need to expose
ShouldStayOnPageAfterHandlingBeforeUnload from WebTestRunner
- exposing via TestRunner is sufficient.

Removed unused WebTestProxyBase::web_widget() accessor.

Remove Hide/MoveValidationMessage method declarations from WebTestProxyBase
- there were no definitions anywhere...

Removed BlinkTestRunner::OnWebTestProxyBaseDestroy because it had an empty body.
Consequently also removed WebTestDelegate::OnWebTestProxyBaseDestroy.

BUG=
==========

to

==========
Remove unneeded code from WebTestProxyBase.

Removed WebTestProxyBase::GetDelegate and GetInterfaces methods,
which were only used to access WebTestDelegate::PrintMessage and
WebTestInterfaces::ShouldStayOnPageAfterHandlingBeforeUnload from
4 methods of WebFrameTestProxy.  Implementing these 4 methods
inside WebTestProxyBase is more consistent with the rest of the code
- i.e. we want WebTestProxy and WebFrameTestProxy to have no logic
and always delegate to WebTestProxyBase instead.  Removing GetDelegate
and GetInterface also avoids unnecessarily exposing full breadth
of these interfaces when only a small subset is needed.

The above allowed WebTestProxyBase::removing web_test_interfaces_ field.

The above also meant that we no longer need to expose
ShouldStayOnPageAfterHandlingBeforeUnload from WebTestRunner
- exposing via TestRunner is sufficient.

Removed unused WebTestProxyBase::web_widget() accessor.
Removed unused TestInterfaces::GetProxy() accessor.

Removed Hide/MoveValidationMessage method declarations from WebTestProxyBase
- there were no definitions anywhere...

Removed BlinkTestRunner::OnWebTestProxyBaseDestroy because it had an empty body.
Consequently also removed WebTestDelegate::OnWebTestProxyBaseDestroy.

BUG=
==========

[jochen (gone - plz use gerrit), 2016-03-14 14:22:25]

lgtm

[Łukasz Anforowicz, 2016-03-14 21:18:15]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-14 21:18:38]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1787743003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1787743003/60001

[Łukasz Anforowicz, 2016-03-14 22:02:15]

The CQ bit was unchecked by lukasza@chromium.org

[Łukasz Anforowicz, 2016-03-14 23:22:12]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2016-03-14 23:22:12]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1787743003/#ps60001
(title: "Fixing accidental reversal of condition in
RunModalBeforeUnloadDialog.")

[commit-bot: I haz the power, 2016-03-14 23:22:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1787743003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1787743003/60001

[commit-bot: I haz the power, 2016-03-14 23:32:26]

Description was changed from

==========
Remove unneeded code from WebTestProxyBase.

Removed WebTestProxyBase::GetDelegate and GetInterfaces methods,
which were only used to access WebTestDelegate::PrintMessage and
WebTestInterfaces::ShouldStayOnPageAfterHandlingBeforeUnload from
4 methods of WebFrameTestProxy.  Implementing these 4 methods
inside WebTestProxyBase is more consistent with the rest of the code
- i.e. we want WebTestProxy and WebFrameTestProxy to have no logic
and always delegate to WebTestProxyBase instead.  Removing GetDelegate
and GetInterface also avoids unnecessarily exposing full breadth
of these interfaces when only a small subset is needed.

The above allowed WebTestProxyBase::removing web_test_interfaces_ field.

The above also meant that we no longer need to expose
ShouldStayOnPageAfterHandlingBeforeUnload from WebTestRunner
- exposing via TestRunner is sufficient.

Removed unused WebTestProxyBase::web_widget() accessor.
Removed unused TestInterfaces::GetProxy() accessor.

Removed Hide/MoveValidationMessage method declarations from WebTestProxyBase
- there were no definitions anywhere...

Removed BlinkTestRunner::OnWebTestProxyBaseDestroy because it had an empty body.
Consequently also removed WebTestDelegate::OnWebTestProxyBaseDestroy.

BUG=
==========

to

==========
Remove unneeded code from WebTestProxyBase.

Removed WebTestProxyBase::GetDelegate and GetInterfaces methods,
which were only used to access WebTestDelegate::PrintMessage and
WebTestInterfaces::ShouldStayOnPageAfterHandlingBeforeUnload from
4 methods of WebFrameTestProxy.  Implementing these 4 methods
inside WebTestProxyBase is more consistent with the rest of the code
- i.e. we want WebTestProxy and WebFrameTestProxy to have no logic
and always delegate to WebTestProxyBase instead.  Removing GetDelegate
and GetInterface also avoids unnecessarily exposing full breadth
of these interfaces when only a small subset is needed.

The above allowed WebTestProxyBase::removing web_test_interfaces_ field.

The above also meant that we no longer need to expose
ShouldStayOnPageAfterHandlingBeforeUnload from WebTestRunner
- exposing via TestRunner is sufficient.

Removed unused WebTestProxyBase::web_widget() accessor.
Removed unused TestInterfaces::GetProxy() accessor.

Removed Hide/MoveValidationMessage method declarations from WebTestProxyBase
- there were no definitions anywhere...

Removed BlinkTestRunner::OnWebTestProxyBaseDestroy because it had an empty body.
Consequently also removed WebTestDelegate::OnWebTestProxyBaseDestroy.

BUG=

Committed: https://crrev.com/e26c3d638b03199daccb3bf602adac2d8a4a7f75
Cr-Commit-Position: refs/heads/master@{#381110}
==========

[commit-bot: I haz the power, 2016-03-14 23:32:28]

Patchset 4 (id:??) landed as
https://crrev.com/e26c3d638b03199daccb3bf602adac2d8a4a7f75
Cr-Commit-Position: refs/heads/master@{#381110}