components/test_runner/test_runner.h - Issue 1787743003: Remove unneeded code from WebTestProxyBase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/test_runner.h

Issue 1787743003: Remove unneeded code from WebTestProxyBase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing accidental reversal of condition in RunModalBeforeUnloadDialog. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/test_runner/test_runner.h

diff --git a/components/test_runner/test_runner.h b/components/test_runner/test_runner.h

index a219ddb6d2ced7ffae85eb6f4fe5372e3dfc3186..b671cee215287d1b1665da684844b895d6bed672 100644

--- a/components/test_runner/test_runner.h

+++ b/components/test_runner/test_runner.h

@@ -70,7 +70,6 @@ class TestRunner : public WebTestRunner,

// WebTestRunner implementation.

bool ShouldGeneratePixelResults() override;

- bool ShouldStayOnPageAfterHandlingBeforeUnload() const override;

bool ShouldDumpAsAudio() const override;

void GetAudioData(std::vector<unsigned char>* buffer_view) const override;

const LayoutDumpFlags& GetLayoutDumpFlags() override;

@@ -81,6 +80,7 @@ class TestRunner : public WebTestRunner,

blink::WebContentSettingsClient* GetWebContentSettings() const override;

// Methods used by WebTestProxyBase.

+ bool shouldStayOnPageAfterHandlingBeforeUnload() const;

bool shouldDumpSelectionRect() const;

bool isPrinting() const;

bool shouldDumpAsTextWithPixelResults();

« no previous file with comments | « components/test_runner/test_interfaces.cc ('k') | components/test_runner/test_runner.cc » ('j') | no next file with comments »