Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: components/test_runner/web_frame_test_proxy.h

Issue 1787743003: Remove unneeded code from WebTestProxyBase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing accidental reversal of condition in RunModalBeforeUnloadDialog. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/test_runner/test_runner.cc ('k') | components/test_runner/web_test_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/web_frame_test_proxy.h
diff --git a/components/test_runner/web_frame_test_proxy.h b/components/test_runner/web_frame_test_proxy.h
index 1cbe11f80ef6c58c6c714f658997e1a3524bb30e..b4d01b798b12f7641fa352df8fe41c3a93f01729 100644
--- a/components/test_runner/web_frame_test_proxy.h
+++ b/components/test_runner/web_frame_test_proxy.h
@@ -148,31 +148,22 @@ class WebFrameTestProxy : public Base {
}
void runModalAlertDialog(const blink::WebString& message) override {
- base_proxy_->GetDelegate()->PrintMessage(std::string("ALERT: ") +
- message.utf8().data() + "\n");
+ base_proxy_->RunModalAlertDialog(message);
}
bool runModalConfirmDialog(const blink::WebString& message) override {
- base_proxy_->GetDelegate()->PrintMessage(std::string("CONFIRM: ") +
- message.utf8().data() + "\n");
- return true;
+ return base_proxy_->RunModalConfirmDialog(message);
}
bool runModalPromptDialog(const blink::WebString& message,
const blink::WebString& default_value,
- blink::WebString*) override {
- base_proxy_->GetDelegate()->PrintMessage(
- std::string("PROMPT: ") + message.utf8().data() + ", default text: " +
- default_value.utf8().data() + "\n");
- return true;
+ blink::WebString* actual_value) override {
+ return base_proxy_->RunModalPromptDialog(message, default_value,
+ actual_value);
}
bool runModalBeforeUnloadDialog(bool is_reload) override {
- base_proxy_->GetDelegate()->PrintMessage(
- std::string("CONFIRM NAVIGATION\n"));
- return !base_proxy_->GetInterfaces()
- ->TestRunner()
- ->ShouldStayOnPageAfterHandlingBeforeUnload();
+ return base_proxy_->RunModalBeforeUnloadDialog(is_reload);
}
void showContextMenu(
« no previous file with comments | « components/test_runner/test_runner.cc ('k') | components/test_runner/web_test_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698