components/test_runner/web_test_delegate.h - Issue 1787743003: Remove unneeded code from WebTestProxyBase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/web_test_delegate.h

Issue 1787743003: Remove unneeded code from WebTestProxyBase. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing accidental reversal of condition in RunModalBeforeUnloadDialog. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/test_runner/web_test_delegate.h

diff --git a/components/test_runner/web_test_delegate.h b/components/test_runner/web_test_delegate.h

index f43ef13c6c162b90b969f342cf1fe90dc5638cb1..e1dd85e22d2df55377c67fb58a34e81551870d73 100644

--- a/components/test_runner/web_test_delegate.h

+++ b/components/test_runner/web_test_delegate.h

@@ -231,7 +231,7 @@ class WebTestDelegate {

// Returns the length of the back/forward history of the main WebView.

virtual int NavigationEntryCount() = 0;

- // The following trigger navigations on the main WebViwe.

+ // The following trigger navigations on the main WebView.

virtual void GoToOffset(int offset) = 0;

virtual void Reload() = 0;

virtual void LoadURLForFrame(const blink::WebURL& url,

@@ -291,8 +291,6 @@ class WebTestDelegate {

blink::WebLocalFrame* frame,

const blink::WebPluginParams& params) = 0;

- virtual void OnWebTestProxyBaseDestroy(WebTestProxyBase* proxy) = 0;

// Convert the position in DIP to native coordinates.

virtual blink::WebPoint ConvertDIPToNative(

const blink::WebPoint& point_in_dip) const = 0;