Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1787443002: Remove lastest_revived_packet from QuicAckFrame since FEC is gone. No functional change expected. (Closed)

Created:
4 years, 9 months ago by rjshade
Modified:
4 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, Fan Yang
Base URL:
https://chromium.googlesource.com/chromium/src.git@116391846
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove lastest_revived_packet from QuicAckFrame since FEC is gone. No functional change expected. Wire format is not changed yet. Merge internal change: 116411121 R=rch@chromium.org BUG=

Patch Set 1 #

Patch Set 2 : Removed revived packet from QuicConnectionLogger #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -133 lines) Patch
M net/quic/quic_connection_logger.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M net/quic/quic_connection_test.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M net/quic/quic_framer.cc View 3 chunks +2 lines, -18 lines 0 comments Download
M net/quic/quic_framer_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_protocol.h View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/quic_protocol.cc View 2 chunks +1 line, -3 lines 0 comments Download
M net/quic/quic_received_packet_manager.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 1 chunk +0 lines, -70 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 2 (0 generated)
rjshade
4 years, 9 months ago (2016-03-10 22:53:56 UTC) #1
Ryan Hamilton
4 years, 9 months ago (2016-03-10 23:11:54 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698