Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: net/quic/quic_framer_test.cc

Issue 1787443002: Remove lastest_revived_packet from QuicAckFrame since FEC is gone. No functional change expected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@116391846
Patch Set: Removed revived packet from QuicConnectionLogger Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/quic_framer.cc ('k') | net/quic/quic_protocol.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_framer.h" 5 #include "net/quic/quic_framer.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 #include <algorithm> 8 #include <algorithm>
9 #include <map> 9 #include <map>
10 #include <string> 10 #include <string>
(...skipping 2258 matching lines...) Expand 10 before | Expand all | Expand 10 after
2269 2269
2270 EXPECT_EQ(QUIC_NO_ERROR, framer_.error()); 2270 EXPECT_EQ(QUIC_NO_ERROR, framer_.error());
2271 ASSERT_TRUE(visitor_.header_.get()); 2271 ASSERT_TRUE(visitor_.header_.get());
2272 EXPECT_TRUE(CheckDecryption(encrypted, !kIncludeVersion, !kIncludePathId)); 2272 EXPECT_TRUE(CheckDecryption(encrypted, !kIncludeVersion, !kIncludePathId));
2273 2273
2274 EXPECT_EQ(0u, visitor_.stream_frames_.size()); 2274 EXPECT_EQ(0u, visitor_.stream_frames_.size());
2275 ASSERT_EQ(1u, visitor_.ack_frames_.size()); 2275 ASSERT_EQ(1u, visitor_.ack_frames_.size());
2276 QuicAckFrame* frame = visitor_.ack_frames_[0]; 2276 QuicAckFrame* frame = visitor_.ack_frames_[0];
2277 EXPECT_EQ(0xBA, frame->entropy_hash); 2277 EXPECT_EQ(0xBA, frame->entropy_hash);
2278 EXPECT_EQ(kLargestObserved, frame->largest_observed); 2278 EXPECT_EQ(kLargestObserved, frame->largest_observed);
2279 EXPECT_EQ(0u, frame->latest_revived_packet);
2280 ASSERT_EQ(500u, frame->missing_packets.NumPacketsSlow()); 2279 ASSERT_EQ(500u, frame->missing_packets.NumPacketsSlow());
2281 EXPECT_EQ(kMissingPacket - 499, frame->missing_packets.Min()); 2280 EXPECT_EQ(kMissingPacket - 499, frame->missing_packets.Min());
2282 EXPECT_EQ(kMissingPacket, frame->missing_packets.Max()); 2281 EXPECT_EQ(kMissingPacket, frame->missing_packets.Max());
2283 2282
2284 // Verify that the packet re-serializes identically. 2283 // Verify that the packet re-serializes identically.
2285 QuicFrames frames; 2284 QuicFrames frames;
2286 frames.push_back(QuicFrame(frame)); 2285 frames.push_back(QuicFrame(frame));
2287 scoped_ptr<QuicPacket> data(BuildDataPacket(*visitor_.header_, frames)); 2286 scoped_ptr<QuicPacket> data(BuildDataPacket(*visitor_.header_, frames));
2288 ASSERT_TRUE(data != nullptr); 2287 ASSERT_TRUE(data != nullptr);
2289 2288
(...skipping 2336 matching lines...) Expand 10 before | Expand all | Expand 10 after
4626 'o', ' ', 'w', 'o', 4625 'o', ' ', 'w', 'o',
4627 'r', 'l', 'd', '!', 4626 'r', 'l', 'd', '!',
4628 }; 4627 };
4629 // clang-format on 4628 // clang-format on
4630 4629
4631 QuicFramerFuzzFunc(packet, arraysize(packet)); 4630 QuicFramerFuzzFunc(packet, arraysize(packet));
4632 } 4631 }
4633 4632
4634 } // namespace test 4633 } // namespace test
4635 } // namespace net 4634 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/quic_framer.cc ('k') | net/quic/quic_protocol.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698