net/quic/quic_protocol.cc - Issue 1787443002: Remove lastest_revived_packet from QuicAckFrame since FEC is gone. No functional change expected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_protocol.cc

Issue 1787443002: Remove lastest_revived_packet from QuicAckFrame since FEC is gone. No functional change expected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@116391846

Patch Set: Removed revived packet from QuicConnectionLogger Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_protocol.cc

diff --git a/net/quic/quic_protocol.cc b/net/quic/quic_protocol.cc

index 438090ed6505801348087807a4f9f769a6bb0900..5c8b63cc61bcd70d12f189ed0b9e4f4a3a90c3b1 100644

--- a/net/quic/quic_protocol.cc

+++ b/net/quic/quic_protocol.cc

@@ -288,8 +288,7 @@ QuicAckFrame::QuicAckFrame()

entropy_hash(0),

is_truncated(false),

largest_observed(0),

- ack_delay_time(QuicTime::Delta::Infinite()),

- latest_revived_packet(0) {}

+ ack_delay_time(QuicTime::Delta::Infinite()) {}

QuicAckFrame::QuicAckFrame(const QuicAckFrame& other) = default;

@@ -525,7 +524,6 @@ ostream& operator<<(ostream& os, const QuicAckFrame& ack_frame) {

<< " ack_delay_time: " << ack_frame.ack_delay_time.ToMicroseconds()

<< " missing_packets: [ " << ack_frame.missing_packets

<< " ] is_truncated: " << ack_frame.is_truncated

- << " revived_packet: " << ack_frame.latest_revived_packet

<< " received_packets: [ ";

for (const std::pair<QuicPacketNumber, QuicTime>& p :

ack_frame.received_packet_times) {

« no previous file with comments | « net/quic/quic_protocol.h ('k') | net/quic/quic_received_packet_manager.cc » ('j') | no next file with comments »