net/quic/quic_framer_test.cc - Issue 1787443002: Remove lastest_revived_packet from QuicAckFrame since FEC is gone. No functional change expected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_framer_test.cc

Issue 1787443002: Remove lastest_revived_packet from QuicAckFrame since FEC is gone. No functional change expected. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@116391846

Patch Set: Removed revived packet from QuicConnectionLogger Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_framer_test.cc

diff --git a/net/quic/quic_framer_test.cc b/net/quic/quic_framer_test.cc

index ca160abdfdbb375ce7ee217fef89c0f6e2dcdc13..ac4a39c289002a3df14f809da347bcd2628f6a58 100644

--- a/net/quic/quic_framer_test.cc

+++ b/net/quic/quic_framer_test.cc

@@ -2276,7 +2276,6 @@ TEST_P(QuicFramerTest, AckFrame500Nacks) {

QuicAckFrame* frame = visitor_.ack_frames_[0];

EXPECT_EQ(0xBA, frame->entropy_hash);

EXPECT_EQ(kLargestObserved, frame->largest_observed);

- EXPECT_EQ(0u, frame->latest_revived_packet);

ASSERT_EQ(500u, frame->missing_packets.NumPacketsSlow());

EXPECT_EQ(kMissingPacket - 499, frame->missing_packets.Min());

EXPECT_EQ(kMissingPacket, frame->missing_packets.Max());

« no previous file with comments | « net/quic/quic_framer.cc ('k') | net/quic/quic_protocol.h » ('j') | no next file with comments »