CC Animation: Erase cc::LayerSettings everywhere.

CC Animation: Erase cc::LayerSettings everywhere.

Also, erase LayerTreeSettings::use_compositor_animation_timelines flag.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/0940d410fd6f1da81a07a963a8b485cee310918f
Cr-Commit-Position: refs/heads/master@{#380914}

[loyso (OOO), 2016-03-11 00:00:16]

Description was changed from

==========
CC Animation: Erase cc::LayerSettings everywhere.

Also, erase LayerTreeSettings::use_compositor_animation_timelines flag.

BUG=575041
==========

to

==========
CC Animation: Erase cc::LayerSettings everywhere.

Also, erase LayerTreeSettings::use_compositor_animation_timelines flag.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[loyso (OOO), 2016-03-11 00:01:06]

Description was changed from

==========
CC Animation: Erase cc::LayerSettings everywhere.

Also, erase LayerTreeSettings::use_compositor_animation_timelines flag.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
CC Animation: Erase cc::LayerSettings everywhere.

Also, erase LayerTreeSettings::use_compositor_animation_timelines flag.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[loyso (OOO), 2016-03-11 00:01:07]

loyso@chromium.org changed reviewers:
+ ajuma@chromium.org, piman@chromium.org, vollick@chromium.org

[ajuma, 2016-03-11 00:40:55]

https://codereview.chromium.org/1783613004/diff/20001/cc/layers/heads_up_disp...
File cc/layers/heads_up_display_layer.cc (right):

https://codereview.chromium.org/1783613004/diff/20001/cc/layers/heads_up_disp...
cc/layers/heads_up_display_layer.cc:21: : Layer(),
This line shouldn't be needed anymore. (And same comment about the constructors
for other subclasses of Layer.)

https://codereview.chromium.org/1783613004/diff/20001/cc/layers/layer_utils_u...
File cc/layers/layer_utils_unittest.cc (right):

https://codereview.chromium.org/1783613004/diff/20001/cc/layers/layer_utils_u...
cc/layers/layer_utils_unittest.cc:30: LayerTreeSettingsForAnimationBoundsTest()
{}
This class doesn't do anything now, so it can be deleted (and places that use it
can just use LayerTreeSettings).

https://codereview.chromium.org/1783613004/diff/20001/cc/test/layer_tree_host...
File cc/test/layer_tree_host_common_test.cc (right):

https://codereview.chromium.org/1783613004/diff/20001/cc/test/layer_tree_host...
cc/test/layer_tree_host_common_test.cc:231: LayerTreeSettingsForCommonTest() {}
This class can be deleted too.

https://codereview.chromium.org/1783613004/diff/20001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/1783613004/diff/20001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_android.cc:448: 
No need for a blank line here.

[piman, 2016-03-11 02:32:43]

LGTM for content/ and ui/compositor

[piman, 2016-03-11 02:32:48]

LGTM for content/ and ui/compositor

[loyso (OOO), 2016-03-11 03:26:57]

Fixed.

https://codereview.chromium.org/1783613004/diff/20001/cc/layers/heads_up_disp...
File cc/layers/heads_up_display_layer.cc (right):

https://codereview.chromium.org/1783613004/diff/20001/cc/layers/heads_up_disp...
cc/layers/heads_up_display_layer.cc:21: : Layer(),
On 2016/03/11 00:40:54, ajuma wrote:
> This line shouldn't be needed anymore. (And same comment about the
constructors
> for other subclasses of Layer.)

Done.

https://codereview.chromium.org/1783613004/diff/20001/cc/layers/layer_utils_u...
File cc/layers/layer_utils_unittest.cc (right):

https://codereview.chromium.org/1783613004/diff/20001/cc/layers/layer_utils_u...
cc/layers/layer_utils_unittest.cc:30: LayerTreeSettingsForAnimationBoundsTest()
{}
On 2016/03/11 00:40:54, ajuma wrote:
> This class doesn't do anything now, so it can be deleted (and places that use
it
> can just use LayerTreeSettings).

Done.

https://codereview.chromium.org/1783613004/diff/20001/cc/test/layer_tree_host...
File cc/test/layer_tree_host_common_test.cc (right):

https://codereview.chromium.org/1783613004/diff/20001/cc/test/layer_tree_host...
cc/test/layer_tree_host_common_test.cc:231: LayerTreeSettingsForCommonTest() {}
On 2016/03/11 00:40:54, ajuma wrote:
> This class can be deleted too.

Done.

https://codereview.chromium.org/1783613004/diff/20001/content/browser/rendere...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/1783613004/diff/20001/content/browser/rendere...
content/browser/renderer_host/render_widget_host_view_android.cc:448: 
On 2016/03/11 00:40:54, ajuma wrote:
> No need for a blank line here.

Done.

[loyso (OOO), 2016-03-11 03:39:46]

loyso@chromium.org changed reviewers:
+ dtrainor@chromium.org

[loyso (OOO), 2016-03-11 03:40:51]

dtrainor@, could you review ui/android and chrome/browser/android/ ?

[loyso (OOO), 2016-03-11 03:43:48]

loyso@chromium.org changed reviewers:
+ kmarshall@chromium.org

[loyso (OOO), 2016-03-11 03:44:32]

kmarshall@, could you review blimp/ ?

[loyso (OOO), 2016-03-11 03:48:23]

loyso@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[loyso (OOO), 2016-03-11 03:49:11]

dalecurtis@, could you review media/ ?

[loyso (OOO), 2016-03-11 03:51:49]

loyso@chromium.org changed reviewers:
+ tkent@chromium.org

[loyso (OOO), 2016-03-11 03:52:38]

tkent@, could you review components/ ?

[David Trainor- moved to gerrit, 2016-03-11 03:54:14]

ui/android and chrome/browser/android lgtm

[Ian Vollick, 2016-03-11 04:12:25]

On 2016/03/11 03:54:14, David Trainor wrote:
> ui/android and chrome/browser/android lgtm

platform/ lgtm

[tkent, 2016-03-11 04:26:00]

components/test_runner/ lgtm

[ajuma, 2016-03-11 14:13:38]

lgtm

[DaleCurtis, 2016-03-11 16:27:58]

lgtm

[loyso (OOO), 2016-03-11 22:50:57]

The CQ bit was checked by loyso@chromium.org

[loyso (OOO), 2016-03-11 22:50:58]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1783613004/#ps40001
(title: "Fix codereview issues.")

[commit-bot: I haz the power, 2016-03-11 22:51:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1783613004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1783613004/40001

[commit-bot: I haz the power, 2016-03-11 22:57:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-11 22:57:25]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/8...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[loyso (OOO), 2016-03-14 00:53:23]

The CQ bit was checked by loyso@chromium.org

[loyso (OOO), 2016-03-14 00:53:24]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org,
tkent@chromium.org, dtrainor@chromium.org, piman@chromium.org,
vollick@chromium.org, dalecurtis@chromium.org
Link to the patchset: https://codereview.chromium.org/1783613004/#ps60001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-03-14 00:53:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1783613004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1783613004/60001

[commit-bot: I haz the power, 2016-03-14 01:30:41]

Description was changed from

==========
CC Animation: Erase cc::LayerSettings everywhere.

Also, erase LayerTreeSettings::use_compositor_animation_timelines flag.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
CC Animation: Erase cc::LayerSettings everywhere.

Also, erase LayerTreeSettings::use_compositor_animation_timelines flag.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-03-14 01:30:44]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-14 01:32:38]

Description was changed from

==========
CC Animation: Erase cc::LayerSettings everywhere.

Also, erase LayerTreeSettings::use_compositor_animation_timelines flag.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
CC Animation: Erase cc::LayerSettings everywhere.

Also, erase LayerTreeSettings::use_compositor_animation_timelines flag.

BUG=575041
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/0940d410fd6f1da81a07a963a8b485cee310918f
Cr-Commit-Position: refs/heads/master@{#380914}
==========

[commit-bot: I haz the power, 2016-03-14 01:32:41]

Patchset 4 (id:??) landed as
https://crrev.com/0940d410fd6f1da81a07a963a8b485cee310918f
Cr-Commit-Position: refs/heads/master@{#380914}