Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 17827005: Get rid of ZoneScope completely. (Closed)

Created:
7 years, 5 months ago by Benedikt Meurer
Modified:
7 years, 5 months ago
Reviewers:
Sven Panne, danno
CC:
v8-dev
Visibility:
Public.

Description

Get rid of ZoneScope completely. There's no need to differentiate between an actual Zone and its scope. Instead we bind the lifetime of the Zone memory to the lifetime of the Zone itself, which is way easier to understand than having to dig through the code looking for zone scopes. Depends on https://codereview.chromium.org/17826004/ R=danno@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=15337

Patch Set 1 #

Total comments: 4

Patch Set 2 : Suggestions from danno #

Unified diffs Side-by-side diffs Delta from patch set Stats (+290 lines, -421 lines) Patch
M src/compiler.h View 1 3 chunks +2 lines, -7 lines 0 comments Download
M src/compiler.cc View 1 3 chunks +1 line, -4 lines 0 comments Download
M src/deoptimizer.cc View 1 4 chunks +9 lines, -11 lines 0 comments Download
M src/gdb-jit.cc View 1 4 chunks +9 lines, -8 lines 0 comments Download
M src/hydrogen-environment-liveness.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/hydrogen-environment-liveness.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/hydrogen-gvn.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/hydrogen-gvn.cc View 1 4 chunks +10 lines, -11 lines 0 comments Download
M src/isolate.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/isolate.cc View 3 chunks +1 line, -5 lines 0 comments Download
M src/json-parser.h View 1 6 chunks +26 lines, -27 lines 0 comments Download
M src/jsregexp.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/jsregexp.cc View 1 5 chunks +6 lines, -8 lines 0 comments Download
M src/liveedit.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/liveedit.cc View 1 5 chunks +9 lines, -10 lines 0 comments Download
M src/runtime.cc View 1 9 chunks +19 lines, -25 lines 0 comments Download
M src/stub-cache.h View 1 chunk +1 line, -1 line 0 comments Download
M src/stub-cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/zone.h View 1 7 chunks +1 line, -48 lines 0 comments Download
M src/zone.cc View 2 chunks +26 lines, -64 lines 0 comments Download
M src/zone-inl.h View 1 2 chunks +0 lines, -12 lines 0 comments Download
M test/cctest/test-ast.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M test/cctest/test-dataflow.cc View 1 6 chunks +14 lines, -15 lines 0 comments Download
M test/cctest/test-liveedit.cc View 1 2 chunks +7 lines, -6 lines 0 comments Download
M test/cctest/test-regexp.cc View 1 35 chunks +123 lines, -127 lines 0 comments Download
M test/cctest/test-strings.cc View 1 8 chunks +17 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Benedikt Meurer
This is a huge cleanup, making it way easier to understand the actual lifetime of ...
7 years, 5 months ago (2013-06-26 12:50:13 UTC) #1
danno
lgtm with comments I am not so certain about the benchmark wins. I also am ...
7 years, 5 months ago (2013-06-26 13:06:58 UTC) #2
Benedikt Meurer
https://codereview.chromium.org/17827005/diff/1/src/json-parser.h File src/json-parser.h (right): https://codereview.chromium.org/17827005/diff/1/src/json-parser.h#newcode325 src/json-parser.h:325: ZoneList<Handle<Object> > properties(8, &zone_); On 2013/06/26 13:06:58, danno wrote: ...
7 years, 5 months ago (2013-06-26 13:34:38 UTC) #3
Benedikt Meurer
7 years, 5 months ago (2013-06-26 13:36:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r15337 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698