Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: src/zone-inl.h

Issue 17827005: Get rid of ZoneScope completely. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Suggestions from danno Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/zone.cc ('k') | test/cctest/test-ast.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 22 matching lines...) Expand all
33 #include "counters.h" 33 #include "counters.h"
34 #include "isolate.h" 34 #include "isolate.h"
35 #include "utils.h" 35 #include "utils.h"
36 #include "v8-counters.h" 36 #include "v8-counters.h"
37 37
38 namespace v8 { 38 namespace v8 {
39 namespace internal { 39 namespace internal {
40 40
41 41
42 inline void* Zone::New(int size) { 42 inline void* Zone::New(int size) {
43 ASSERT(scope_nesting_ > 0);
44 // Round up the requested size to fit the alignment. 43 // Round up the requested size to fit the alignment.
45 size = RoundUp(size, kAlignment); 44 size = RoundUp(size, kAlignment);
46 45
47 // If the allocation size is divisible by 8 then we return an 8-byte aligned 46 // If the allocation size is divisible by 8 then we return an 8-byte aligned
48 // address. 47 // address.
49 if (kPointerSize == 4 && kAlignment == 4) { 48 if (kPointerSize == 4 && kAlignment == 4) {
50 position_ += ((~size) & 4) & (reinterpret_cast<intptr_t>(position_) & 4); 49 position_ += ((~size) & 4) & (reinterpret_cast<intptr_t>(position_) & 4);
51 } else { 50 } else {
52 ASSERT(kAlignment >= kPointerSize); 51 ASSERT(kAlignment >= kPointerSize);
53 } 52 }
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 return zone_->New(static_cast<int>(size)); 102 return zone_->New(static_cast<int>(size));
104 } 103 }
105 104
106 105
107 template <typename T> 106 template <typename T>
108 void* ZoneList<T>::operator new(size_t size, Zone* zone) { 107 void* ZoneList<T>::operator new(size_t size, Zone* zone) {
109 return zone->New(static_cast<int>(size)); 108 return zone->New(static_cast<int>(size));
110 } 109 }
111 110
112 111
113 ZoneScope::ZoneScope(Zone* zone, ZoneScopeMode mode)
114 : zone_(zone), mode_(mode) {
115 zone_->scope_nesting_++;
116 }
117
118
119 bool ZoneScope::ShouldDeleteOnExit() {
120 return zone_->scope_nesting_ == 1 && mode_ == DELETE_ON_EXIT;
121 }
122
123
124 } } // namespace v8::internal 112 } } // namespace v8::internal
125 113
126 #endif // V8_ZONE_INL_H_ 114 #endif // V8_ZONE_INL_H_
OLDNEW
« no previous file with comments | « src/zone.cc ('k') | test/cctest/test-ast.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698