Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: src/compiler.h

Issue 17827005: Get rid of ZoneScope completely. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Suggestions from danno Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler.h
diff --git a/src/compiler.h b/src/compiler.h
index 53d0690f96a3b6fe79b0022c79744a74c5a498c9..5afe6539c415421a0c2133b122d13ffa28daae35 100644
--- a/src/compiler.h
+++ b/src/compiler.h
@@ -441,22 +441,18 @@ class CompilationInfoWithZone: public CompilationInfo {
explicit CompilationInfoWithZone(Handle<Script> script)
: CompilationInfo(script, &zone_, &phase_zone_),
zone_(script->GetIsolate()),
- zone_scope_(&zone_, DELETE_ON_EXIT),
phase_zone_(script->GetIsolate()) {}
explicit CompilationInfoWithZone(Handle<SharedFunctionInfo> shared_info)
: CompilationInfo(shared_info, &zone_, &phase_zone_),
zone_(shared_info->GetIsolate()),
- zone_scope_(&zone_, DELETE_ON_EXIT),
phase_zone_(shared_info->GetIsolate()) {}
explicit CompilationInfoWithZone(Handle<JSFunction> closure)
: CompilationInfo(closure, &zone_, &phase_zone_),
zone_(closure->GetIsolate()),
- zone_scope_(&zone_, DELETE_ON_EXIT),
phase_zone_(closure->GetIsolate()) {}
CompilationInfoWithZone(HydrogenCodeStub* stub, Isolate* isolate)
: CompilationInfo(stub, isolate, &zone_, &phase_zone_),
zone_(isolate),
- zone_scope_(&zone_, DELETE_ON_EXIT),
phase_zone_(isolate) {}
// Virtual destructor because a CompilationInfoWithZone has to exit the
@@ -468,7 +464,6 @@ class CompilationInfoWithZone: public CompilationInfo {
private:
Zone zone_;
- ZoneScope zone_scope_;
Zone phase_zone_;
};
@@ -643,12 +638,12 @@ class CompilationPhase BASE_EMBEDDED {
const char* name() const { return name_; }
Isolate* isolate() const { return isolate_; }
- Zone* zone() const { return zone_scope_.zone(); }
+ Zone* zone() const { return zone_; }
private:
const char* name_;
Isolate* isolate_;
- ZoneScope zone_scope_;
+ Zone* zone_;
unsigned start_allocation_size_;
int64_t start_ticks_;
« no previous file with comments | « no previous file | src/compiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698