Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 1782453003: Windows dump_syms: Add unittest for a PDB containing PDATA/XDATA

Created:
4 years, 6 months ago by jon.turney
Modified:
4 years, 6 months ago
Reviewers:
Ted Mielczarek
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@pdb-pdata
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Windows dump_syms: Add unittest for a PDB containing PDATA/XDATA Also fix a couple of issues with dump_syms_unittest: * Turn DumpSymsRegressionTest into a parameterized test so it's easier to see which test file is failing * Convert dump_syms_regtest.sym to DOS line endings, being careful to preserve the required spaces at the end of 'STACK WIN' lines There remain some issues with the these tests: * Test #4 (omap_reorder_bbs) and #5 (dump_syms_regtest64) will not pass without the .exe corresponding to the .pdb present, to provide the INFO line * Test #5 does not pass, seemingly due a mis-match in the PDB age between the .pdb file and the .sym file * Test #5 does not pass without the .exe corresponding to the .pdb present, to provide the CFI BUG=None

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18125 lines, -2981 lines) Patch
M src/common/windows/pdb_source_line_writer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/tools/windows/dump_syms/dump_syms_unittest.cc View 4 chunks +36 lines, -31 lines 0 comments Download
M src/tools/windows/dump_syms/testdata/dump_syms_regtest.sym View 1 chunk +2945 lines, -2945 lines 0 comments Download
A + src/tools/windows/dump_syms/testdata/pdb_pdata.cc View 4 chunks +15 lines, -4 lines 0 comments Download
A src/tools/windows/dump_syms/testdata/pdb_pdata_in_exe.exe View Binary file 0 comments Download
A src/tools/windows/dump_syms/testdata/pdb_pdata_in_exe.pdb View Binary file 0 comments Download
A src/tools/windows/dump_syms/testdata/pdb_pdata_in_exe.sym View 1 chunk +7565 lines, -0 lines 0 comments Download
A src/tools/windows/dump_syms/testdata/pdb_pdata_in_pdb.pdb View Binary file 0 comments Download
A src/tools/windows/dump_syms/testdata/pdb_pdata_in_pdb.sym View 1 chunk +7564 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 2 (1 generated)
jon.turney
4 years, 6 months ago (2016-03-09 14:27:05 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698