Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 1773183003: Windows dump_syms: Add dumping of x86_64 CFI from PDB files

Created:
4 years, 9 months ago by jon.turney
Modified:
4 years, 6 months ago
Reviewers:
Ted Mielczarek
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@warning-fix
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Windows dump_syms: Add dumping of x86_64 CFI from PDB files Look for PDATA/XDATA streams in the PDB file, and use those to generate CFI. Since those streams are only present in the PDB for PECOFF executables linked using the /DEBUGTYPE:PDATA flag, we fall-back to the existing behaviour of reading the corresponding PECOFF executable (if available) for PDATA/XDATA. Generalize FindAndLoadOmapTable() as FindAndLoadDebugStream() Factor out interpeting the PDATA/XDATA and outputting CFI lines as PrintCFIFromXData(), and parameterize that by a class which performs RVA to VA translation as appropriate to PDB streams or a PECOFF executable image loaded with ImageHlp. BUG=None

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -95 lines) Patch
M src/common/windows/dia_util.h View 2 chunks +66 lines, -0 lines 0 comments Download
M src/common/windows/omap.cc View 1 chunk +2 lines, -45 lines 0 comments Download
M src/common/windows/pdb_source_line_writer.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/common/windows/pdb_source_line_writer.cc View 3 chunks +151 lines, -50 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (3 generated)
jon.turney
4 years, 9 months ago (2016-03-09 14:18:36 UTC) #2
jon.turney
4 years, 9 months ago (2016-03-10 17:14:12 UTC) #4
jon.turney
4 years, 9 months ago (2016-03-10 17:22:23 UTC) #5
jon.turney
4 years, 9 months ago (2016-03-10 17:22:23 UTC) #6

          

Powered by Google App Engine
This is Rietveld 408576698