Windows dump_syms: Add unittest for a PDB containing PDATA/XDATA

src/tools/windows/dump_syms/dump_syms_unittest.cc

 // Copyright 2003 Google Inc. All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 // notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 // copyright notice, this list of conditions and the following disclaimer
@@ skipping 38 matching lines @@
   // A PDB file with OMAP data for an image that has been function-level
   // reordered.
   L"omap_reorder_funcs",
   // A PDB file with OMAP data for an image that had new content injected, all
   // of it with source data.
   L"omap_stretched_filled",
   // A PDB file with OMAP data for an image that had new content injected, but
   // without source data.
   L"omap_stretched",
   // A PDB file with OMAP data for an image that has been basic block reordered.
-  L"omap_reorder_bbs",  
+  L"omap_reorder_bbs",
   // A 64bit PDB file with no OMAP data.
   L"dump_syms_regtest64",
+  // A 64bit PDB file with PDATA
+  L"pdb_pdata_in_pdb",
+  // A 64bit PDB file with an exe to provide PDATA
+  L"pdb_pdata_in_exe",
 };
 
 void TrimLastComponent(const std::wstring& path,
                        std::wstring* trimmed,
                        std::wstring* component) {
   size_t len = path.size();
   while (len > 0 && path[len - 1] != '\\')
     --len;
 
   if (component != NULL)
@@ skipping 84 matching lines @@
 
   char buffer[4096] = {};
   while (true) {
     size_t bytes_read = ::fread(buffer, 1, sizeof(buffer), f);
     if (bytes_read == 0)
       break;
     content->append(buffer, bytes_read);
   }
 }
 
-class DumpSymsRegressionTest : public testing::Test {
+class DumpSymsRegressionTest : public testing::TestWithParam<const wchar_t *> {
  public:
   virtual void SetUp() {
     std::wstring self_dir;
     ASSERT_TRUE(GetSelfDirectory(&self_dir));
     dump_syms_exe = self_dir + L"\\dump_syms.exe";
 
     TrimLastComponent(self_dir, &testdata_dir, NULL);
     testdata_dir += L"\\testdata";
   }
 
   std::wstring dump_syms_exe;
   std::wstring testdata_dir;
 };
 
 }  //namespace
 
-TEST_F(DumpSymsRegressionTest, EnsureDumpedSymbolsMatch) {
-  for (size_t i = 0; i < sizeof(kRootNames) / sizeof(kRootNames[0]); ++i) {
-    const wchar_t* root_name = kRootNames[i];
+TEST_P(DumpSymsRegressionTest, EnsureDumpedSymbolsMatch) {
+    const wchar_t* root_name = GetParam();
     std::wstring root_path = testdata_dir + L"\\" + root_name;
 
     std::wstring sym_path = root_path + L".sym";
     std::string expected_symbols;
     ASSERT_NO_FATAL_FAILURE(GetFileContents(sym_path, &expected_symbols));
 
     std::wstring pdb_path = root_path + L".pdb";
     std::wstring command_line = L"\"" + dump_syms_exe + L"\" \"" +
         pdb_path + L"\"";
     std::string symbols;
     ASSERT_NO_FATAL_FAILURE(RunCommand(command_line, &symbols));
 
     EXPECT_EQ(expected_symbols, symbols);
-  }
 }
 
+INSTANTIATE_TEST_CASE_P(DumpSyms, DumpSymsRegressionTest,
+                        testing::ValuesIn(kRootNames));
+
 }  // namespace dump_syms
 }  // namespace windows
-}  // namespace tools
+}  // namespace tools