src/common/windows/pdb_source_line_writer.cc - Issue 1782453003: Windows dump_syms: Add unittest for a PDB containing PDATA/XDATA

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/common/windows/pdb_source_line_writer.cc

Issue 1782453003: Windows dump_syms: Add unittest for a PDB containing PDATA/XDATA Base URL: https://chromium.googlesource.com/breakpad/breakpad.git@pdb-pdata

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/common/windows/pdb_source_line_writer.cc

diff --git a/src/common/windows/pdb_source_line_writer.cc b/src/common/windows/pdb_source_line_writer.cc

index 522ec1a125c42792107b20e8072d704c3989187f..8126e333f7356da429912c2af2fe4772965f0e82 100644

--- a/src/common/windows/pdb_source_line_writer.cc

+++ b/src/common/windows/pdb_source_line_writer.cc

@@ -1381,7 +1381,6 @@ bool PDBSourceLineWriter::GetPEInfo(PEModuleInfo *info) {

}

if (code_file_.empty() && !FindPEFile()) {

- fprintf(stderr, "Couldn't locate EXE or DLL file.\n");

return false;

}

« no previous file with comments | « no previous file | src/tools/windows/dump_syms/dump_syms_unittest.cc » ('j') | no next file with comments »