Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1781993002: Mozart: Compute hits using 4x4 matrix. (Closed)

Created:
4 years, 9 months ago by jeffbrown
Modified:
4 years, 9 months ago
Reviewers:
abarth
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@moz-10
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Mozart: Compute hits using 4x4 matrix. Use SkMatrix44 instead of SkMatrix when manipulating transformation matrices in the scene graph. This is made easier by introducing a TransformPair to hold the transformation matrix and its inverse which is computed and cached on demand. BUG= R=abarth@google.com Committed: https://chromium.googlesource.com/external/mojo/+/7d2312b2f55ae9e7776258fe959866736bcc0143

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -53 lines) Patch
M mojo/skia/type_converters.h View 3 chunks +12 lines, -1 line 0 comments Download
M mojo/skia/type_converters.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M services/gfx/compositor/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M services/gfx/compositor/graph/node_def.h View 10 chunks +14 lines, -12 lines 0 comments Download
M services/gfx/compositor/graph/node_def.cc View 17 chunks +22 lines, -28 lines 0 comments Download
M services/gfx/compositor/graph/scene_content.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/gfx/compositor/graph/scene_content.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/gfx/compositor/graph/scene_def.h View 1 chunk +1 line, -0 lines 0 comments Download
M services/gfx/compositor/graph/scene_def.cc View 7 chunks +14 lines, -7 lines 0 comments Download
M services/gfx/compositor/graph/snapshot.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A services/gfx/compositor/graph/transform_pair.h View 1 chunk +36 lines, -0 lines 0 comments Download
A services/gfx/compositor/graph/transform_pair.cc View 1 chunk +35 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1782733002 Patch 20001

Messages

Total messages: 5 (2 generated)
jeffbrown
4 years, 9 months ago (2016-03-10 02:54:14 UTC) #2
abarth
lgtm
4 years, 9 months ago (2016-03-10 03:20:39 UTC) #3
jeffbrown
4 years, 9 months ago (2016-03-10 16:25:51 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
7d2312b2f55ae9e7776258fe959866736bcc0143 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698