Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1782733002: Mozart: The great RectF-ication. (Closed)

Created:
4 years, 9 months ago by jeffbrown
Modified:
4 years, 9 months ago
Reviewers:
abarth
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@moz-9
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Mozart: The great RectF-ication. Clean up the Mozart interfaces to consistently use floating point representations when manipulating abstract geometry (transforms, clips, hit test points) and integer representations when working with actual pixels (viewports). BUG= R=abarth@google.com Committed: https://chromium.googlesource.com/external/mojo/+/563af9feb0fed43e590b7296cc51cabd4e341ccd

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+288 lines, -225 lines) Patch
M apps/moterm/moterm_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/ui/noodles/rasterizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/ui/pdf_viewer/pdf_viewer.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/ui/png_viewer/png_viewer.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/ui/shapes/shapes_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/ui/spinning_cube/spinning_cube_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/ui/tile/tile_view.h View 1 chunk +1 line, -1 line 0 comments Download
M examples/ui/tile/tile_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/geometry.mojom.dart View 4 chunks +56 lines, -56 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/gfx/composition/hit_tests.mojom.dart View 6 chunks +6 lines, -6 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/gfx/composition/nodes.mojom.dart View 10 chunks +14 lines, -14 lines 0 comments Download
M mojo/services/geometry/cpp/formatting.h View 1 chunk +4 lines, -2 lines 0 comments Download
M mojo/services/geometry/cpp/formatting.cc View 3 chunks +12 lines, -3 lines 0 comments Download
M mojo/services/geometry/cpp/geometry_util.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/geometry/cpp/geometry_util.cc View 2 chunks +15 lines, -12 lines 0 comments Download
M mojo/services/geometry/interfaces/geometry.mojom View 1 chunk +13 lines, -13 lines 0 comments Download
M mojo/services/gfx/composition/cpp/formatting.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/gfx/composition/interfaces/hit_tests.mojom View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/gfx/composition/interfaces/nodes.mojom View 4 chunks +9 lines, -9 lines 0 comments Download
M mojo/services/gfx/composition/interfaces/renderers.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/skia/type_converters.h View 1 chunk +30 lines, -12 lines 0 comments Download
M mojo/skia/type_converters.cc View 3 chunks +39 lines, -9 lines 0 comments Download
M mojo/ui/associates/mock_hit_tester.h View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/ui/associates/mock_hit_tester.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/ui/associates/test_helpers.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/ui/associates/view_tree_hit_tester_client.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/ui/associates/view_tree_hit_tester_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/ui/associates/view_tree_hit_tester_client_apptest.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M services/gfx/compositor/backend/gpu_rasterizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/gfx/compositor/compositor_engine.h View 1 chunk +1 line, -1 line 0 comments Download
M services/gfx/compositor/compositor_engine.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/gfx/compositor/graph/node_def.h View 10 chunks +19 lines, -19 lines 0 comments Download
M services/gfx/compositor/graph/node_def.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M services/gfx/compositor/graph/scene_def.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M services/gfx/compositor/graph/snapshot.h View 1 chunk +1 line, -1 line 0 comments Download
M services/gfx/compositor/graph/snapshot.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M services/gfx/compositor/render/render_frame.h View 3 chunks +5 lines, -5 lines 0 comments Download
M services/gfx/compositor/render/render_frame.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/gfx/compositor/renderer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M services/gfx/compositor/renderer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/input_manager/input_dispatcher_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/ui/view_manager/view_registry.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 5 (2 generated)
jeffbrown
4 years, 9 months ago (2016-03-10 01:34:06 UTC) #2
abarth
lgtm
4 years, 9 months ago (2016-03-10 03:18:18 UTC) #3
jeffbrown
4 years, 9 months ago (2016-03-10 16:24:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
563af9feb0fed43e590b7296cc51cabd4e341ccd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698