components/password_manager/core/browser/password_manager_metrics_util.h - Issue 1781633002: Mark PasswordManager.InfoBarResponse as obsolete

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_metrics_util.h

Issue 1781633002: Mark PasswordManager.InfoBarResponse as obsolete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@593295_remove_groups_code

Patch Set: Just rebased Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/save_password_infobar_delegate.cc ('k') | components/password_manager/core/browser/password_manager_metrics_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_metrics_util.h

diff --git a/components/password_manager/core/browser/password_manager_metrics_util.h b/components/password_manager/core/browser/password_manager_metrics_util.h

index 7a8fd55bbb5f19b21da26a9a5e431dc4bfbca09d..1360f204356363fcb2c05cb01f11b87af7cc8adb 100644

--- a/components/password_manager/core/browser/password_manager_metrics_util.h

+++ b/components/password_manager/core/browser/password_manager_metrics_util.h

@@ -128,15 +128,6 @@ void LogUMAHistogramBoolean(const std::string& name, bool sample);

// Log the |reason| a user dismissed the password manager UI.

void LogUIDismissalReason(UIDismissalReason reason);

-// Given a ResponseType, log the appropriate UIResponse. We'll use this

-// mapping to migrate from "PasswordManager.InfoBarResponse" to

-// "PasswordManager.UIDismissalReason" so we can accurately evaluate the

-// impact of the bubble UI.

-//

-// TODO(mkwst): Drop this (and the infobar metric itself) once the new metric

-// has rolled out to stable.

-void LogUIDismissalReason(ResponseType type);

// Log the appropriate display disposition.

void LogUIDisplayDisposition(UIDisplayDisposition disposition);