Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.mm

Issue 1781633002: Mark PasswordManager.InfoBarResponse as obsolete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@593295_remove_groups_code
Patch Set: Just rebased Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.mm
diff --git a/ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.mm b/ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.mm
index 67da5c4e5e8399278dda1e61f9ccd100523b22c2..17a2ef247bccdfbf053f80e98fa5864f9229d350 100644
--- a/ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.mm
+++ b/ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.mm
@@ -39,16 +39,14 @@ void IOSChromeSavePasswordInfoBarDelegate::Create(
}
IOSChromeSavePasswordInfoBarDelegate::~IOSChromeSavePasswordInfoBarDelegate() {
- UMA_HISTOGRAM_ENUMERATION("PasswordManager.InfoBarResponse",
- infobar_response_,
- password_manager::metrics_util::NUM_RESPONSE_TYPES);
+ password_manager::metrics_util::LogUIDismissalReason(infobar_response_);
}
IOSChromeSavePasswordInfoBarDelegate::IOSChromeSavePasswordInfoBarDelegate(
bool is_smart_lock_branding_enabled,
scoped_ptr<PasswordFormManager> form_to_save)
: form_to_save_(std::move(form_to_save)),
- infobar_response_(password_manager::metrics_util::NO_RESPONSE),
+ infobar_response_(password_manager::metrics_util::NO_DIRECT_INTERACTION),
is_smart_lock_branding_enabled_(is_smart_lock_branding_enabled) {}
infobars::InfoBarDelegate::Type
@@ -86,14 +84,14 @@ base::string16 IOSChromeSavePasswordInfoBarDelegate::GetButtonLabel(
bool IOSChromeSavePasswordInfoBarDelegate::Accept() {
DCHECK(form_to_save_);
form_to_save_->Save();
- infobar_response_ = password_manager::metrics_util::REMEMBER_PASSWORD;
+ infobar_response_ = password_manager::metrics_util::CLICKED_SAVE;
return true;
}
bool IOSChromeSavePasswordInfoBarDelegate::Cancel() {
DCHECK(form_to_save_);
form_to_save_->PermanentlyBlacklist();
- infobar_response_ = password_manager::metrics_util::NEVER_REMEMBER_PASSWORD;
+ infobar_response_ = password_manager::metrics_util::CLICKED_NEVER;
return true;
}
« no previous file with comments | « ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698