Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Issue 1780603002: blink: Rename bindings/ methods to prefix with get when they collide. (Closed)

Created:
4 years, 9 months ago by danakj
Modified:
4 years, 9 months ago
Reviewers:
haraken
CC:
chromium-reviews, shans, rjwright, blink-reviews-style_chromium.org, tzik, mlamouri+watch-blink_chromium.org, blink-reviews-animation_chromium.org, blink-reviews-css, horo+watch_chromium.org, dcheng, falken, kinuko+worker_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, nhiroki, darktears, blink-reviews, apavlov+blink_chromium.org, rwlbuis, kinuko+fileapi, blink-worker-reviews_chromium.org, Eric Willigers, chrishtr, esprehn, pdr., piman, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

blink: Rename bindings/ methods to prefix with get when they collide. This focuses on bindings/ to rename methods that are named foo() and that return a Foo*, which will have collisions when foo() is renamed to Foo() in chromium style. This patch uses the following to do many of the replacements: git gs '\b$foo()'|grep '\.\(cpp\|h\|cc\):'|cut -d: -f1|sort|uniq|xargs sed -ie 's/\b$foo()/$getFoo()/g' R=haraken@chromium.org BUG=582312 Committed: https://crrev.com/73388b47a7f4818dbadfe27345b8cfaddb34964e Cr-Commit-Position: refs/heads/master@{#380225}

Patch Set 1 #

Patch Set 2 : clash-bindings: rebase #

Patch Set 3 : clash-bindings: rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -144 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/Dictionary.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ExceptionState.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/NPV8Object.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptController.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp View 1 2 18 chunks +49 lines, -49 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp View 19 chunks +29 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Binding.h View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PerContextData.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8StringResource.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ValueCache.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationStack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSInterpolationType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/InterpolableValueTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/Interpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/InterpolationEffectTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/InterpolationType.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/InvalidatableInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/InvalidatableInterpolation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/PrimitiveInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/SVGInterpolationType.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/SampledEffect.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/StyleInterpolation.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/TypedInterpolationValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableClipPathOperation.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableClipPathOperation.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableShadow.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/animatable/AnimatableShapeValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/clipboard/DataTransferItem.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/events/DragEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/DragEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/DragEvent.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/DragEventInit.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/MouseEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Frame.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RemoteFrame.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/filesystem/DataTransferItemFileSystem.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrame.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
danakj
This one's smaller :S
4 years, 9 months ago (2016-03-09 00:52:14 UTC) #1
haraken
LGTM
4 years, 9 months ago (2016-03-09 00:59:27 UTC) #2
commit-bot: I haz the power
This CL has an open dependency (Issue 1773813007 Patch 30001). Please resolve the dependency and ...
4 years, 9 months ago (2016-03-09 21:00:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780603002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780603002/40001
4 years, 9 months ago (2016-03-09 21:02:29 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-09 21:24:55 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 21:26:19 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/73388b47a7f4818dbadfe27345b8cfaddb34964e
Cr-Commit-Position: refs/heads/master@{#380225}

Powered by Google App Engine
This is Rietveld 408576698