Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/V8ValueCache.cpp

Issue 1780603002: blink: Rename bindings/ methods to prefix with get when they collide. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: clash-bindings: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 16 matching lines...) Expand all
27 27
28 #include "bindings/core/v8/V8Binding.h" 28 #include "bindings/core/v8/V8Binding.h"
29 #include "wtf/text/StringHash.h" 29 #include "wtf/text/StringHash.h"
30 #include <utility> 30 #include <utility>
31 31
32 namespace blink { 32 namespace blink {
33 33
34 StringCacheMapTraits::MapType* StringCacheMapTraits::MapFromWeakCallbackInfo( 34 StringCacheMapTraits::MapType* StringCacheMapTraits::MapFromWeakCallbackInfo(
35 const v8::WeakCallbackInfo<WeakCallbackDataType>& data) 35 const v8::WeakCallbackInfo<WeakCallbackDataType>& data)
36 { 36 {
37 return &(V8PerIsolateData::from(data.GetIsolate())->stringCache()->m_stringC ache); 37 return &(V8PerIsolateData::from(data.GetIsolate())->getStringCache()->m_stri ngCache);
38 } 38 }
39 39
40 void StringCacheMapTraits::Dispose( 40 void StringCacheMapTraits::Dispose(
41 v8::Isolate* isolate, v8::Global<v8::String> value, StringImpl* key) 41 v8::Isolate* isolate, v8::Global<v8::String> value, StringImpl* key)
42 { 42 {
43 V8PerIsolateData::from(isolate)->stringCache()->InvalidateLastString(); 43 V8PerIsolateData::from(isolate)->getStringCache()->InvalidateLastString();
44 key->deref(); 44 key->deref();
45 } 45 }
46 46
47 void StringCacheMapTraits::DisposeWeak(const v8::WeakCallbackInfo<WeakCallbackDa taType>& data) 47 void StringCacheMapTraits::DisposeWeak(const v8::WeakCallbackInfo<WeakCallbackDa taType>& data)
48 { 48 {
49 V8PerIsolateData::from(data.GetIsolate())->stringCache()->InvalidateLastStri ng(); 49 V8PerIsolateData::from(data.GetIsolate())->getStringCache()->InvalidateLastS tring();
50 data.GetParameter()->deref(); 50 data.GetParameter()->deref();
51 } 51 }
52 52
53 void StringCacheMapTraits::OnWeakCallback(const v8::WeakCallbackInfo<WeakCallbac kDataType>& data) 53 void StringCacheMapTraits::OnWeakCallback(const v8::WeakCallbackInfo<WeakCallbac kDataType>& data)
54 { 54 {
55 V8PerIsolateData::from(data.GetIsolate())->stringCache()->InvalidateLastStri ng(); 55 V8PerIsolateData::from(data.GetIsolate())->getStringCache()->InvalidateLastS tring();
56 } 56 }
57 57
58 58
59 CompressibleStringCacheMapTraits::MapType* CompressibleStringCacheMapTraits::Map FromWeakCallbackInfo( 59 CompressibleStringCacheMapTraits::MapType* CompressibleStringCacheMapTraits::Map FromWeakCallbackInfo(
60 const v8::WeakCallbackInfo<WeakCallbackDataType>& data) 60 const v8::WeakCallbackInfo<WeakCallbackDataType>& data)
61 { 61 {
62 return &(V8PerIsolateData::from(data.GetIsolate())->stringCache()->m_compres sibleStringCache); 62 return &(V8PerIsolateData::from(data.GetIsolate())->getStringCache()->m_comp ressibleStringCache);
63 } 63 }
64 64
65 void CompressibleStringCacheMapTraits::Dispose( 65 void CompressibleStringCacheMapTraits::Dispose(
66 v8::Isolate* isolate, v8::Global<v8::String> value, CompressibleStringImpl* key) 66 v8::Isolate* isolate, v8::Global<v8::String> value, CompressibleStringImpl* key)
67 { 67 {
68 key->deref(); 68 key->deref();
69 } 69 }
70 70
71 void CompressibleStringCacheMapTraits::DisposeWeak(const v8::WeakCallbackInfo<We akCallbackDataType>& data) 71 void CompressibleStringCacheMapTraits::DisposeWeak(const v8::WeakCallbackInfo<We akCallbackDataType>& data)
72 { 72 {
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 return newString; 217 return newString;
218 } 218 }
219 219
220 void StringCache::InvalidateLastString() 220 void StringCache::InvalidateLastString()
221 { 221 {
222 m_lastStringImpl = nullptr; 222 m_lastStringImpl = nullptr;
223 m_lastV8String.Reset(); 223 m_lastV8String.Reset();
224 } 224 }
225 225
226 } // namespace blink 226 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698