third_party/WebKit/Source/bindings/core/v8/NPV8Object.cpp - Issue 1780603002: blink: Rename bindings/ methods to prefix with get when they collide.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/NPV8Object.cpp

Issue 1780603002: blink: Rename bindings/ methods to prefix with get when they collide. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clash-bindings: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ExceptionState.h ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/NPV8Object.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/NPV8Object.cpp b/third_party/WebKit/Source/bindings/core/v8/NPV8Object.cpp

index a24ec202973e317b77505b980c65ca5f072ba7a0..ce0c4f0d3be51dbfb273c19947d96a3c5583bfba 100644

--- a/third_party/WebKit/Source/bindings/core/v8/NPV8Object.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/NPV8Object.cpp

@@ -140,7 +140,7 @@ NPObject* npCreateV8ScriptObject(v8::Isolate* isolate, NPP npp, v8::Local<v8::Ob

if (V8PerContextData* perContextData = V8PerContextData::from(object->CreationContext())) {

int v8ObjectHash = object->GetIdentityHash();

ASSERT(v8ObjectHash);

- V8NPObjectMap* v8NPObjectMap = perContextData->v8NPObjectMap();

+ V8NPObjectMap* v8NPObjectMap = perContextData->getV8NPObjectMap();

V8NPObjectMap::iterator iter = v8NPObjectMap->find(v8ObjectHash);

if (iter != v8NPObjectMap->end()) {

V8NPObjectVector& objects = iter->value;

@@ -195,7 +195,7 @@ void disposeUnderlyingV8Object(v8::Isolate* isolate, NPObject* npObject)

v8::Local<v8::Object> v8Object = v8::Local<v8::Object>::New(isolate, v8NpObject->v8Object);

ASSERT(!v8Object->CreationContext().IsEmpty());

if (V8PerContextData* perContextData = V8PerContextData::from(v8Object->CreationContext())) {

- V8NPObjectMap* v8NPObjectMap = perContextData->v8NPObjectMap();

+ V8NPObjectMap* v8NPObjectMap = perContextData->getV8NPObjectMap();

int v8ObjectHash = v8Object->GetIdentityHash();

ASSERT(v8ObjectHash);

V8NPObjectMap::iterator iter = v8NPObjectMap->find(v8ObjectHash);