third_party/WebKit/Source/bindings/core/v8/V8ValueCache.cpp - Issue 1780603002: blink: Rename bindings/ methods to prefix with get when they collide.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ValueCache.cpp

Issue 1780603002: blink: Rename bindings/ methods to prefix with get when they collide. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clash-bindings: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8StringResource.h ('k') | third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8ValueCache.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ValueCache.cpp b/third_party/WebKit/Source/bindings/core/v8/V8ValueCache.cpp

index 0ff99ce67a53c6b52841938098c58d1d112c1bc9..605dbedc045849da049c1c85c20cb7b85a1c0ab9 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8ValueCache.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8ValueCache.cpp

@@ -34,32 +34,32 @@ namespace blink {

StringCacheMapTraits::MapType* StringCacheMapTraits::MapFromWeakCallbackInfo(

const v8::WeakCallbackInfo<WeakCallbackDataType>& data)

{

- return &(V8PerIsolateData::from(data.GetIsolate())->stringCache()->m_stringCache);

+ return &(V8PerIsolateData::from(data.GetIsolate())->getStringCache()->m_stringCache);

}

void StringCacheMapTraits::Dispose(

v8::Isolate* isolate, v8::Global<v8::String> value, StringImpl* key)

{

- V8PerIsolateData::from(isolate)->stringCache()->InvalidateLastString();

+ V8PerIsolateData::from(isolate)->getStringCache()->InvalidateLastString();

key->deref();

}

void StringCacheMapTraits::DisposeWeak(const v8::WeakCallbackInfo<WeakCallbackDataType>& data)

{

- V8PerIsolateData::from(data.GetIsolate())->stringCache()->InvalidateLastString();

+ V8PerIsolateData::from(data.GetIsolate())->getStringCache()->InvalidateLastString();

data.GetParameter()->deref();

}

void StringCacheMapTraits::OnWeakCallback(const v8::WeakCallbackInfo<WeakCallbackDataType>& data)

{

- V8PerIsolateData::from(data.GetIsolate())->stringCache()->InvalidateLastString();

+ V8PerIsolateData::from(data.GetIsolate())->getStringCache()->InvalidateLastString();

}

CompressibleStringCacheMapTraits::MapType* CompressibleStringCacheMapTraits::MapFromWeakCallbackInfo(

const v8::WeakCallbackInfo<WeakCallbackDataType>& data)

{

- return &(V8PerIsolateData::from(data.GetIsolate())->stringCache()->m_compressibleStringCache);

+ return &(V8PerIsolateData::from(data.GetIsolate())->getStringCache()->m_compressibleStringCache);

}

void CompressibleStringCacheMapTraits::Dispose(