Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Issue 1780513002: Remove LOG(FATAL) as this can't be called late in Chrome shutdown. (Closed)

Created:
4 years, 9 months ago by Will Harris
Modified:
4 years, 9 months ago
Reviewers:
AlvarezD.AA11, scottmg
CC:
chromium-reviews, grt+watch_chromium.org, vmpstr+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove LOG(FATAL) as this can't be called late in Chrome shutdown. CloseHandle hooks sometimes hit after Chrome has already started shutting down, on Windows 7, so the logging engine has already been destructed at this point. Therefore these are not safe to be called. This restores original functionality before crrev.com/1762443002 BUG=571304, 475872 Committed: https://crrev.com/4801736b6383b4496b53e051bf8d04da20c71424 Cr-Commit-Position: refs/heads/master@{#379945}

Patch Set 1 #

Patch Set 2 : comments here are actually useful. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M base/win/scoped_handle.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M base/win/scoped_handle_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
Will Harris
PTAL
4 years, 9 months ago (2016-03-08 21:03:11 UTC) #3
scottmg
lgtm
4 years, 9 months ago (2016-03-08 21:19:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780513002/20001
4 years, 9 months ago (2016-03-08 21:28:28 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-08 22:38:05 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/4801736b6383b4496b53e051bf8d04da20c71424 Cr-Commit-Position: refs/heads/master@{#379945}
4 years, 9 months ago (2016-03-08 22:39:29 UTC) #11
AlvarezD.AA11
4 years, 9 months ago (2016-03-08 22:54:38 UTC) #13
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698