Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2371)

Unified Diff: base/win/scoped_handle.cc

Issue 1780513002: Remove LOG(FATAL) as this can't be called late in Chrome shutdown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments here are actually useful. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/win/scoped_handle_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/win/scoped_handle.cc
diff --git a/base/win/scoped_handle.cc b/base/win/scoped_handle.cc
index d718717ca4a3bebe15389339340ae830cf10adf6..f358c99b6f011073f19706c1643a8529e7c54b75 100644
--- a/base/win/scoped_handle.cc
+++ b/base/win/scoped_handle.cc
@@ -46,7 +46,7 @@ base::LazyInstance<NativeLock>::Leaky g_lock = LAZY_INSTANCE_INITIALIZER;
bool CloseHandleWrapper(HANDLE handle) {
if (!::CloseHandle(handle))
- LOG(FATAL) << "CloseHandle failed.";
+ CHECK(false); // CloseHandle failed.
return true;
}
@@ -168,7 +168,7 @@ void ActiveVerifier::StartTracking(HANDLE handle, const void* owner,
if (!result.second) {
Info other = result.first->second;
base::debug::Alias(&other);
- LOG(FATAL) << "Attempt to start tracking already tracked handle.";
+ CHECK(false); // Attempt to start tracking already tracked handle.
}
}
@@ -180,12 +180,12 @@ void ActiveVerifier::StopTracking(HANDLE handle, const void* owner,
AutoNativeLock lock(*lock_);
HandleMap::iterator i = map_.find(handle);
if (i == map_.end())
- LOG(FATAL) << "Attempting to close an untracked handle.";
+ CHECK(false); // Attempting to close an untracked handle.
Info other = i->second;
if (other.owner != owner) {
base::debug::Alias(&other);
- LOG(FATAL) << "Attempting to close a handle not owned by opener.";
+ CHECK(false); // Attempting to close a handle not owned by opener.
}
map_.erase(i);
@@ -209,7 +209,7 @@ void ActiveVerifier::OnHandleBeingClosed(HANDLE handle) {
Info other = i->second;
base::debug::Alias(&other);
- LOG(FATAL) << "CloseHandle called on tracked handle.";
+ CHECK(false); // CloseHandle called on tracked handle.
}
} // namespace
« no previous file with comments | « no previous file | base/win/scoped_handle_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698