Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: base/win/scoped_handle_unittest.cc

Issue 1780513002: Remove LOG(FATAL) as this can't be called late in Chrome shutdown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments here are actually useful. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/win/scoped_handle.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/win/scoped_handle_unittest.cc
diff --git a/base/win/scoped_handle_unittest.cc b/base/win/scoped_handle_unittest.cc
index deabf28e84e15ef4b46f2e9ad87df77bec9a2b9b..598e3f4150dd69e6479a772b688dea9cc7655545 100644
--- a/base/win/scoped_handle_unittest.cc
+++ b/base/win/scoped_handle_unittest.cc
@@ -51,7 +51,7 @@ TEST(ScopedHandleTest, ActiveVerifierTrackedHasBeenClosed) {
base::win::ScopedHandle handle_holder(handle);
ntclose(handle);
// Destructing a ScopedHandle with an illegally closed handle should fail.
- }, "CloseHandle failed.");
+ }, "");
}
TEST(ScopedHandleTest, ActiveVerifierDoubleTracking) {
@@ -62,7 +62,7 @@ TEST(ScopedHandleTest, ActiveVerifierDoubleTracking) {
ASSERT_DEATH({
base::win::ScopedHandle handle_holder2(handle);
- }, "Attempt to start tracking already tracked handle.");
+ }, "");
}
TEST(ScopedHandleTest, ActiveVerifierWrongOwner) {
@@ -73,7 +73,7 @@ TEST(ScopedHandleTest, ActiveVerifierWrongOwner) {
ASSERT_DEATH({
base::win::ScopedHandle handle_holder2;
handle_holder2.handle_ = handle;
- }, "Attempting to close a handle not owned by opener.");
+ }, "");
ASSERT_TRUE(handle_holder.IsValid());
handle_holder.Close();
}
@@ -85,7 +85,7 @@ TEST(ScopedHandleTest, ActiveVerifierUntrackedHandle) {
ASSERT_DEATH({
base::win::ScopedHandle handle_holder;
handle_holder.handle_ = handle;
- }, "Attempting to close an untracked handle.");
+ }, "");
ASSERT_TRUE(::CloseHandle(handle));
}
« no previous file with comments | « base/win/scoped_handle.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698