Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1767293005: Add creation tracking for ActiveVerifier. (Closed)

Created:
4 years, 9 months ago by Will Harris
Modified:
4 years, 9 months ago
Reviewers:
scottmg
CC:
chromium-reviews, grt+watch_chromium.org, vmpstr+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add creation tracking for ActiveVerifier. Sometimes the ActiveVerifier gets instantiated inside chrome_child's copy of base and sometimes inside chrome.exe's copy of base. The ActiveVerifier should only be running from chrome.exe's copy of base, but before enforcing this, am adding a check to determine what is causing this unpredictability. See bug for the gory details. BUG=592753 Committed: https://crrev.com/1f9673dbd1b71cfa5a0dc5ab06509368153bcb20 Cr-Commit-Position: refs/heads/master@{#379996}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M base/win/scoped_handle.cc View 4 chunks +7 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
Will Harris
PTAL
4 years, 9 months ago (2016-03-08 21:20:25 UTC) #4
scottmg
lgtm
4 years, 9 months ago (2016-03-08 21:25:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1767293005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1767293005/20001
4 years, 9 months ago (2016-03-08 22:41:15 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 9 months ago (2016-03-09 00:33:13 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-09 00:34:08 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f9673dbd1b71cfa5a0dc5ab06509368153bcb20
Cr-Commit-Position: refs/heads/master@{#379996}

Powered by Google App Engine
This is Rietveld 408576698