Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1778663005: Call RecordWriteIntoCode when storing the target object in the reloc info on all platforms. (Closed)

Created:
4 years, 9 months ago by Hannes Payer (out of office)
Modified:
4 years, 9 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Call RecordWriteIntoCode when storing the target object in the reloc info on all platforms. BUG=chromium:561449 LOG=n Committed: https://crrev.com/dedfe5aee5f656d3c17e4549bf8ad891bc31e935 Cr-Commit-Position: refs/heads/master@{#34655}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M src/ia32/assembler-ia32-inl.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/assembler-x64-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x87/assembler-x87-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Hannes Payer (out of office)
4 years, 9 months ago (2016-03-09 14:56:13 UTC) #2
ulan
lgtm
4 years, 9 months ago (2016-03-10 07:29:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1778663005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1778663005/40001
4 years, 9 months ago (2016-03-10 09:15:02 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-10 09:35:53 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 09:36:27 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dedfe5aee5f656d3c17e4549bf8ad891bc31e935
Cr-Commit-Position: refs/heads/master@{#34655}

Powered by Google App Engine
This is Rietveld 408576698