Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: src/x87/assembler-x87-inl.h

Issue 1778663005: Call RecordWriteIntoCode when storing the target object in the reloc info on all platforms. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x64/assembler-x64-inl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 WriteBarrierMode write_barrier_mode, 133 WriteBarrierMode write_barrier_mode,
134 ICacheFlushMode icache_flush_mode) { 134 ICacheFlushMode icache_flush_mode) {
135 DCHECK(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT); 135 DCHECK(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT);
136 Memory::Object_at(pc_) = target; 136 Memory::Object_at(pc_) = target;
137 if (icache_flush_mode != SKIP_ICACHE_FLUSH) { 137 if (icache_flush_mode != SKIP_ICACHE_FLUSH) {
138 Assembler::FlushICache(isolate_, pc_, sizeof(Address)); 138 Assembler::FlushICache(isolate_, pc_, sizeof(Address));
139 } 139 }
140 if (write_barrier_mode == UPDATE_WRITE_BARRIER && 140 if (write_barrier_mode == UPDATE_WRITE_BARRIER &&
141 host() != NULL && 141 host() != NULL &&
142 target->IsHeapObject()) { 142 target->IsHeapObject()) {
143 host()->GetHeap()->incremental_marking()->RecordWrite( 143 host()->GetHeap()->incremental_marking()->RecordWriteIntoCode(
144 host(), &Memory::Object_at(pc_), HeapObject::cast(target)); 144 host(), this, HeapObject::cast(target));
145 } 145 }
146 } 146 }
147 147
148 148
149 Address RelocInfo::target_external_reference() { 149 Address RelocInfo::target_external_reference() {
150 DCHECK(rmode_ == RelocInfo::EXTERNAL_REFERENCE); 150 DCHECK(rmode_ == RelocInfo::EXTERNAL_REFERENCE);
151 return Memory::Address_at(pc_); 151 return Memory::Address_at(pc_);
152 } 152 }
153 153
154 154
(...skipping 386 matching lines...) Expand 10 before | Expand all | Expand 10 after
541 541
542 Operand::Operand(Immediate imm) { 542 Operand::Operand(Immediate imm) {
543 // [disp/r] 543 // [disp/r]
544 set_modrm(0, ebp); 544 set_modrm(0, ebp);
545 set_dispr(imm.x_, imm.rmode_); 545 set_dispr(imm.x_, imm.rmode_);
546 } 546 }
547 } // namespace internal 547 } // namespace internal
548 } // namespace v8 548 } // namespace v8
549 549
550 #endif // V8_X87_ASSEMBLER_X87_INL_H_ 550 #endif // V8_X87_ASSEMBLER_X87_INL_H_
OLDNEW
« no previous file with comments | « src/x64/assembler-x64-inl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698