Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/ia32/assembler-ia32-inl.h

Issue 1778663005: Call RecordWriteIntoCode when storing the target object in the reloc info on all platforms. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/x64/assembler-x64-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 WriteBarrierMode write_barrier_mode, 132 WriteBarrierMode write_barrier_mode,
133 ICacheFlushMode icache_flush_mode) { 133 ICacheFlushMode icache_flush_mode) {
134 DCHECK(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT); 134 DCHECK(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT);
135 Memory::Object_at(pc_) = target; 135 Memory::Object_at(pc_) = target;
136 if (icache_flush_mode != SKIP_ICACHE_FLUSH) { 136 if (icache_flush_mode != SKIP_ICACHE_FLUSH) {
137 Assembler::FlushICache(isolate_, pc_, sizeof(Address)); 137 Assembler::FlushICache(isolate_, pc_, sizeof(Address));
138 } 138 }
139 if (write_barrier_mode == UPDATE_WRITE_BARRIER && 139 if (write_barrier_mode == UPDATE_WRITE_BARRIER &&
140 host() != NULL && 140 host() != NULL &&
141 target->IsHeapObject()) { 141 target->IsHeapObject()) {
142 host()->GetHeap()->incremental_marking()->RecordWrite( 142 host()->GetHeap()->incremental_marking()->RecordWriteIntoCode(
143 host(), &Memory::Object_at(pc_), HeapObject::cast(target)); 143 host(), this, HeapObject::cast(target));
144 } 144 }
145 } 145 }
146 146
147 147
148 Address RelocInfo::target_external_reference() { 148 Address RelocInfo::target_external_reference() {
149 DCHECK(rmode_ == RelocInfo::EXTERNAL_REFERENCE); 149 DCHECK(rmode_ == RelocInfo::EXTERNAL_REFERENCE);
150 return Memory::Address_at(pc_); 150 return Memory::Address_at(pc_);
151 } 151 }
152 152
153 153
(...skipping 392 matching lines...) Expand 10 before | Expand all | Expand 10 after
546 546
547 Operand::Operand(Immediate imm) { 547 Operand::Operand(Immediate imm) {
548 // [disp/r] 548 // [disp/r]
549 set_modrm(0, ebp); 549 set_modrm(0, ebp);
550 set_dispr(imm.x_, imm.rmode_); 550 set_dispr(imm.x_, imm.rmode_);
551 } 551 }
552 } // namespace internal 552 } // namespace internal
553 } // namespace v8 553 } // namespace v8
554 554
555 #endif // V8_IA32_ASSEMBLER_IA32_INL_H_ 555 #endif // V8_IA32_ASSEMBLER_IA32_INL_H_
OLDNEW
« no previous file with comments | « no previous file | src/x64/assembler-x64-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698