Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Side by Side Diff: src/x64/assembler-x64-inl.h

Issue 1778663005: Call RecordWriteIntoCode when storing the target object in the reloc info on all platforms. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/assembler-ia32-inl.h ('k') | src/x87/assembler-x87-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_X64_ASSEMBLER_X64_INL_H_ 5 #ifndef V8_X64_ASSEMBLER_X64_INL_H_
6 #define V8_X64_ASSEMBLER_X64_INL_H_ 6 #define V8_X64_ASSEMBLER_X64_INL_H_
7 7
8 #include "src/x64/assembler-x64.h" 8 #include "src/x64/assembler-x64.h"
9 9
10 #include "src/base/cpu.h" 10 #include "src/base/cpu.h"
(...skipping 392 matching lines...) Expand 10 before | Expand all | Expand 10 after
403 WriteBarrierMode write_barrier_mode, 403 WriteBarrierMode write_barrier_mode,
404 ICacheFlushMode icache_flush_mode) { 404 ICacheFlushMode icache_flush_mode) {
405 DCHECK(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT); 405 DCHECK(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT);
406 Memory::Object_at(pc_) = target; 406 Memory::Object_at(pc_) = target;
407 if (icache_flush_mode != SKIP_ICACHE_FLUSH) { 407 if (icache_flush_mode != SKIP_ICACHE_FLUSH) {
408 Assembler::FlushICache(isolate_, pc_, sizeof(Address)); 408 Assembler::FlushICache(isolate_, pc_, sizeof(Address));
409 } 409 }
410 if (write_barrier_mode == UPDATE_WRITE_BARRIER && 410 if (write_barrier_mode == UPDATE_WRITE_BARRIER &&
411 host() != NULL && 411 host() != NULL &&
412 target->IsHeapObject()) { 412 target->IsHeapObject()) {
413 host()->GetHeap()->incremental_marking()->RecordWrite( 413 host()->GetHeap()->incremental_marking()->RecordWriteIntoCode(
414 host(), &Memory::Object_at(pc_), HeapObject::cast(target)); 414 host(), this, HeapObject::cast(target));
415 } 415 }
416 } 416 }
417 417
418 418
419 Address RelocInfo::target_runtime_entry(Assembler* origin) { 419 Address RelocInfo::target_runtime_entry(Assembler* origin) {
420 DCHECK(IsRuntimeEntry(rmode_)); 420 DCHECK(IsRuntimeEntry(rmode_));
421 return origin->runtime_entry_at(pc_); 421 return origin->runtime_entry_at(pc_);
422 } 422 }
423 423
424 424
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
610 void Operand::set_disp64(int64_t disp) { 610 void Operand::set_disp64(int64_t disp) {
611 DCHECK_EQ(1, len_); 611 DCHECK_EQ(1, len_);
612 int64_t* p = reinterpret_cast<int64_t*>(&buf_[len_]); 612 int64_t* p = reinterpret_cast<int64_t*>(&buf_[len_]);
613 *p = disp; 613 *p = disp;
614 len_ += sizeof(disp); 614 len_ += sizeof(disp);
615 } 615 }
616 } // namespace internal 616 } // namespace internal
617 } // namespace v8 617 } // namespace v8
618 618
619 #endif // V8_X64_ASSEMBLER_X64_INL_H_ 619 #endif // V8_X64_ASSEMBLER_X64_INL_H_
OLDNEW
« no previous file with comments | « src/ia32/assembler-ia32-inl.h ('k') | src/x87/assembler-x87-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698