Improve test-serialize test cases.

Improve test-serialize test cases.

Changes include:
 - better test coverage for builds with snapshot
 - write snapshot blobs to buffer instead of test serialization files
 - renamed tests

R=machenbach@chromium.org

Committed: https://crrev.com/a65edb8be62624ec01cf3ce790867cffa0c573dd
Cr-Commit-Position: refs/heads/master@{#34657}

[Michael Achenbach, 2016-03-10 09:26:46]

lgtm - thanks for the patch!

https://codereview.chromium.org/1777213002/diff/1/test/cctest/test-serialize.cc
File test/cctest/test-serialize.cc (left):

https://codereview.chromium.org/1777213002/diff/1/test/cctest/test-serialize....
test/cctest/test-serialize.cc:205: if (DefaultSnapshotAvailable()) return;
So, the tests are now executed also with snapshot builds? I'm in favor of it if
the tests are fast.

https://codereview.chromium.org/1777213002/diff/1/tools/testrunner/local/test...
File tools/testrunner/local/testsuite.py (left):

https://codereview.chromium.org/1777213002/diff/1/tools/testrunner/local/test...
tools/testrunner/local/testsuite.py:113: def SetupWorkingDirectory(self):
Please also remove the call in v8/tools/testrunner/network/endpoint.py

[Michael Achenbach, 2016-03-10 09:28:08]

Is the cmd line parameter for the testing serialization file still useful for
something?

[Yang, 2016-03-10 09:29:34]

On 2016/03/10 09:28:08, Michael Achenbach wrote:
> Is the cmd line parameter for the testing serialization file still useful for
> something?

you are right. I should remove it from flag-definitions.

[Yang, 2016-03-10 09:33:50]

Addressed comments.

https://codereview.chromium.org/1777213002/diff/1/test/cctest/test-serialize.cc
File test/cctest/test-serialize.cc (left):

https://codereview.chromium.org/1777213002/diff/1/test/cctest/test-serialize....
test/cctest/test-serialize.cc:205: if (DefaultSnapshotAvailable()) return;
On 2016/03/10 09:26:46, Michael Achenbach wrote:
> So, the tests are now executed also with snapshot builds? I'm in favor of it
if
> the tests are fast.

Yes. These tests should be fast enough. Each test would run approximately the
same time as a mksnapshot run and a normal startup.

https://codereview.chromium.org/1777213002/diff/1/tools/testrunner/local/test...
File tools/testrunner/local/testsuite.py (left):

https://codereview.chromium.org/1777213002/diff/1/tools/testrunner/local/test...
tools/testrunner/local/testsuite.py:113: def SetupWorkingDirectory(self):
On 2016/03/10 09:26:46, Michael Achenbach wrote:
> Please also remove the call in v8/tools/testrunner/network/endpoint.py

Thanks. I missed this one.

[Yang, 2016-03-10 09:33:54]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2016-03-10 09:34:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1777213002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1777213002/1

[commit-bot: I haz the power, 2016-03-10 09:57:52]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-10 09:58:32]

Description was changed from

==========
Improve test-serialize test cases.

Changes include:
 - better test coverage for builds with snapshot
 - write snapshot blobs to buffer instead of test serialization files
 - renamed tests

R=machenbach@chromium.org
==========

to

==========
Improve test-serialize test cases.

Changes include:
 - better test coverage for builds with snapshot
 - write snapshot blobs to buffer instead of test serialization files
 - renamed tests

R=machenbach@chromium.org

Committed: https://crrev.com/a65edb8be62624ec01cf3ce790867cffa0c573dd
Cr-Commit-Position: refs/heads/master@{#34657}
==========

[commit-bot: I haz the power, 2016-03-10 09:58:33]

Patchset 1 (id:??) landed as
https://crrev.com/a65edb8be62624ec01cf3ce790867cffa0c573dd
Cr-Commit-Position: refs/heads/master@{#34657}