Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: tools/testrunner/local/testsuite.py

Issue 1777213002: Improve test-serialize test cases. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« test/cctest/test-serialize.cc ('K') | « tools/run-tests.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testrunner/local/testsuite.py
diff --git a/tools/testrunner/local/testsuite.py b/tools/testrunner/local/testsuite.py
index fd013d75684c1e47aa95039af6a33d2a90ae0e2b..b4b342503f2c7d4438d61032fb253cfd197a27df 100644
--- a/tools/testrunner/local/testsuite.py
+++ b/tools/testrunner/local/testsuite.py
@@ -102,7 +102,6 @@ class TestSuite(object):
def __init__(self, name, root):
# Note: This might be called concurrently from different processes.
- # Changing harddisk state should be done in 'SetupWorkingDirectory' below.
self.name = name # string
self.root = root # string containing path
self.tests = None # list of TestCase objects
@@ -110,11 +109,6 @@ class TestSuite(object):
self.wildcards = None # dictionary mapping test paths to list of outcomes
self.total_duration = None # float, assigned on demand
- def SetupWorkingDirectory(self):
Michael Achenbach 2016/03/10 09:26:46 Please also remove the call in v8/tools/testrunner
Yang 2016/03/10 09:33:50 Thanks. I missed this one.
- # This is called once per test suite object in a multi-process setting.
- # Multi-process-unsafe work-directory setup can go here.
- pass
-
def shell(self):
return "d8"
« test/cctest/test-serialize.cc ('K') | « tools/run-tests.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698