Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1780173002: Allow Math.random to be called when creating a custom startup snapshot. (Closed)

Created:
4 years, 9 months ago by Yang
Modified:
4 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@testserialize
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Allow Math.random to be called when creating a custom startup snapshot. R=jkummerow@chromium.org BUG=v8:4810 LOG=N Committed: https://crrev.com/6a7ec6a3bf779cdd41c66a768fd7a37195ed7b7f Cr-Commit-Position: refs/heads/master@{#34705}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -12 lines) Patch
M src/js/math.js View 1 3 chunks +12 lines, -8 lines 0 comments Download
M src/runtime/runtime-maths.cc View 1 chunk +12 lines, -2 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Yang
4 years, 9 months ago (2016-03-10 10:29:33 UTC) #1
Jakob Kummerow
lgtm
4 years, 9 months ago (2016-03-10 11:02:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780173002/1
4 years, 9 months ago (2016-03-10 11:45:21 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/11393)
4 years, 9 months ago (2016-03-10 11:59:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1780173002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1780173002/20001
4 years, 9 months ago (2016-03-11 07:45:58 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-11 08:08:05 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/6a7ec6a3bf779cdd41c66a768fd7a37195ed7b7f Cr-Commit-Position: refs/heads/master@{#34705}
4 years, 9 months ago (2016-03-11 08:08:37 UTC) #12
Yang
4 years, 9 months ago (2016-03-14 10:05:07 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1798863003/ by yangguo@chromium.org.

The reason for reverting is: Regresses performance on base64 benchmark..

Powered by Google App Engine
This is Rietveld 408576698