Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 1777883003: [serializer] allow test-serialize/PartialSerializerCustomContext to optimize. (Closed)

Created:
4 years, 9 months ago by Yang
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@testserialize
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[serializer] allow test-serialize/PartialSerializerCustomContext to optimize. Previously, optimization has been disabled because of an assertion failure, which requires the context to be linked into the weak native context list of the heap. R=jkummerow@chromium.org Committed: https://crrev.com/fe921661119a2f28e2be8ecbae53a26bcc39d805 Cr-Commit-Position: refs/heads/master@{#34661}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M test/cctest/test-serialize.cc View 2 chunks +7 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (4 generated)
Yang
4 years, 9 months ago (2016-03-10 09:22:09 UTC) #1
Jakob Kummerow
lgtm
4 years, 9 months ago (2016-03-10 09:24:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777883003/1
4 years, 9 months ago (2016-03-10 10:31:09 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/16656)
4 years, 9 months ago (2016-03-10 10:51:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1777883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1777883003/1
4 years, 9 months ago (2016-03-10 10:55:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-10 11:18:18 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-10 11:18:58 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe921661119a2f28e2be8ecbae53a26bcc39d805
Cr-Commit-Position: refs/heads/master@{#34661}

Powered by Google App Engine
This is Rietveld 408576698