Fix the password bubble titles for android.

Fix the password bubble titles for android.

It should be "Do you want to save the password for <site>?" and "Saved passwords for <site>".

BUG=592382
Committed: https://crrev.com/5fe6793b2e0afeb3e395ea49dd346bf5747b0f14
Cr-Commit-Position: refs/heads/master@{#380413}

[vasilii, 2016-03-09 14:06:20]

vasilii@chromium.org changed reviewers:
+ engedy@chromium.org

[vasilii, 2016-03-09 14:06:21]

Hi Balazs,

please review.

[engedy, 2016-03-09 15:33:16]

LGTM, but note that I'm not an OWNER Of c/b/ui/passwords.

https://codereview.chromium.org/1776673003/diff/1/chrome/browser/ui/passwords...
File chrome/browser/ui/passwords/manage_passwords_state_unittest.cc (right):

https://codereview.chromium.org/1776673003/diff/1/chrome/browser/ui/passwords...
chrome/browser/ui/passwords/manage_passwords_state_unittest.cc:68: // Returns a
PasswordFormManager containing nothing as a best match.
Isn't this the best match out of test_stored_forms()?

https://codereview.chromium.org/1776673003/diff/1/chrome/browser/ui/passwords...
chrome/browser/ui/passwords/manage_passwords_state_unittest.cc:127:
test_form_manager->OnGetPasswordStoreResults(std::move(test_stored_forms()));
nit: Getting a reference to a vector, and then stealing that vector seems a bit
confusing. :-)

https://codereview.chromium.org/1776673003/diff/1/chrome/browser/ui/passwords...
File chrome/browser/ui/passwords/manage_passwords_view_utils.cc (right):

https://codereview.chromium.org/1776673003/diff/1/chrome/browser/ui/passwords...
chrome/browser/ui/passwords/manage_passwords_view_utils.cc:81:
DCHECK(!password_manager::FacetURI::FromPotentiallyInvalidSpec(
nit:

DCHECK(!password_manager::IsValidAndroidFacetURI(form_origin_url.spec());

Same below.

[vasilii, 2016-03-10 11:11:36]

https://codereview.chromium.org/1776673003/diff/1/chrome/browser/ui/passwords...
File chrome/browser/ui/passwords/manage_passwords_state_unittest.cc (right):

https://codereview.chromium.org/1776673003/diff/1/chrome/browser/ui/passwords...
chrome/browser/ui/passwords/manage_passwords_state_unittest.cc:68: // Returns a
PasswordFormManager containing nothing as a best match.
On 2016/03/09 15:33:16, engedy wrote:
> Isn't this the best match out of test_stored_forms()?

Done.

https://codereview.chromium.org/1776673003/diff/1/chrome/browser/ui/passwords...
chrome/browser/ui/passwords/manage_passwords_state_unittest.cc:127:
test_form_manager->OnGetPasswordStoreResults(std::move(test_stored_forms()));
On 2016/03/09 15:33:16, engedy wrote:
> nit: Getting a reference to a vector, and then stealing that vector seems a
bit
> confusing. :-)

Done.

https://codereview.chromium.org/1776673003/diff/1/chrome/browser/ui/passwords...
File chrome/browser/ui/passwords/manage_passwords_view_utils.cc (right):

https://codereview.chromium.org/1776673003/diff/1/chrome/browser/ui/passwords...
chrome/browser/ui/passwords/manage_passwords_view_utils.cc:81:
DCHECK(!password_manager::FacetURI::FromPotentiallyInvalidSpec(
On 2016/03/09 15:33:16, engedy wrote:
> nit:
> 
> DCHECK(!password_manager::IsValidAndroidFacetURI(form_origin_url.spec());
> 
> Same below.

Done.

[vasilii, 2016-03-10 14:56:22]

vasilii@chromium.org changed reviewers:
+ vabr@chromium.org

[vasilii, 2016-03-10 14:56:22]

Hi Vaclav,

please review (as least ios_chrome_password_manager_client).

[vabr (Chromium), 2016-03-10 15:29:11]

On 2016/03/10 14:56:22, vasilii wrote:
> Hi Vaclav,
> 
> please review (as least ios_chrome_password_manager_client).

ios_chrome_password_manager_client LGTM, I can have a look at the rest later
today if you want me to.

Cheers,
Vaclav

[vasilii, 2016-03-10 15:35:18]

On 2016/03/10 15:29:11, vabr (Chromium) wrote:
> On 2016/03/10 14:56:22, vasilii wrote:
> > Hi Vaclav,
> > 
> > please review (as least ios_chrome_password_manager_client).
> 
> ios_chrome_password_manager_client LGTM, I can have a look at the rest later
> today if you want me to.
> 
> Cheers,
> Vaclav

It's optional. I am committing now.

[vasilii, 2016-03-10 15:35:23]

The CQ bit was checked by vasilii@chromium.org

[vasilii, 2016-03-10 15:35:23]

The patchset sent to the CQ was uploaded after l-g-t-m from engedy@chromium.org
Link to the patchset: https://codereview.chromium.org/1776673003/#ps60001
(title: "fix the tests")

[commit-bot: I haz the power, 2016-03-10 15:35:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1776673003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1776673003/60001

[commit-bot: I haz the power, 2016-03-10 15:41:13]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-10 15:42:21]

Description was changed from

==========
Fix the password bubble titles for android.

It should be "Do you want to save the password for <site>?" and "Saved passwords
for <site>".

BUG=592382
==========

to

==========
Fix the password bubble titles for android.

It should be "Do you want to save the password for <site>?" and "Saved passwords
for <site>".

BUG=592382

Committed: https://crrev.com/5fe6793b2e0afeb3e395ea49dd346bf5747b0f14
Cr-Commit-Position: refs/heads/master@{#380413}
==========

[commit-bot: I haz the power, 2016-03-10 15:42:22]

Patchset 4 (id:??) landed as
https://crrev.com/5fe6793b2e0afeb3e395ea49dd346bf5747b0f14
Cr-Commit-Position: refs/heads/master@{#380413}