chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc - Issue 1776673003: Fix the password bubble titles for android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

Issue 1776673003: Fix the password bubble titles for android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix the tests Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_ui_controller.cc ('k') | chrome/browser/ui/passwords/manage_passwords_view_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

index 0c40ffc45c11abdea07963f391a9b36df1ff24c5..783370dde7f29bdc20237a133d6006e027b540aa 100644

--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc

@@ -605,7 +605,8 @@ TEST_F(ManagePasswordsUIControllerTest, ChooseCredentialCancel) {

TEST_F(ManagePasswordsUIControllerTest, AutoSignin) {

ScopedVector<autofill::PasswordForm> local_credentials;

local_credentials.push_back(new autofill::PasswordForm(test_local_form()));

- controller()->OnAutoSignin(std::move(local_credentials));

+ controller()->OnAutoSignin(std::move(local_credentials),

+ test_local_form().origin);

EXPECT_EQ(password_manager::ui::AUTO_SIGNIN_STATE, controller()->GetState());

EXPECT_EQ(test_local_form().origin, controller()->GetOrigin());

ASSERT_FALSE(controller()->GetCurrentForms().empty());

@@ -668,7 +669,8 @@ TEST_F(ManagePasswordsUIControllerTest, AutoSigninFirstRunAfterNavigation) {

TEST_F(ManagePasswordsUIControllerTest, AutofillDuringAutoSignin) {

ScopedVector<autofill::PasswordForm> local_credentials;

local_credentials.push_back(new autofill::PasswordForm(test_local_form()));

- controller()->OnAutoSignin(std::move(local_credentials));

+ controller()->OnAutoSignin(std::move(local_credentials),

+ test_local_form().origin);

ExpectIconAndControllerStateIs(password_manager::ui::AUTO_SIGNIN_STATE);

scoped_ptr<autofill::PasswordForm> test_form(

new autofill::PasswordForm(test_local_form()));