chrome/browser/ui/passwords/manage_passwords_bubble_model.cc - Issue 1776673003: Fix the password bubble titles for android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

Issue 1776673003: Fix the password bubble titles for android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix the tests Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

index 50ccf00613fa18bd2fad95a47d16995f10042268..3ea39f6ee3c32b076794c0654ca40bbff2117689 100644

--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc

@@ -350,14 +350,14 @@ void ManagePasswordsBubbleModel::UpdatePendingStateTitle() {

? PasswordTittleType::SAVE_PASSWORD

: PasswordTittleType::SAVE_ACCOUNT);

GetSavePasswordDialogTitleTextAndLinkRange(

- web_contents()->GetVisibleURL(), origin(),

+ web_contents()->GetVisibleURL(), origin_,

GetSmartLockBrandingState(GetProfile()) !=

password_bubble_experiment::SmartLockBranding::NONE,

type, &title_, &title_brand_link_range_);

}

void ManagePasswordsBubbleModel::UpdateManageStateTitle() {

- GetManagePasswordsDialogTitleText(web_contents()->GetVisibleURL(), origin(),

+ GetManagePasswordsDialogTitleText(web_contents()->GetVisibleURL(), origin_,

&title_);

}