Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_view_utils.cc

Issue 1776673003: Fix the password bubble titles for android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix the tests Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_view_utils.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_view_utils.cc b/chrome/browser/ui/passwords/manage_passwords_view_utils.cc
index 274d75439eda57a4ac5523abbdb66a532fbb4dd9..f70cc62c6eed98b698c4d7d2695da4e13f304e64 100644
--- a/chrome/browser/ui/passwords/manage_passwords_view_utils.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_view_utils.cc
@@ -78,6 +78,7 @@ void GetSavePasswordDialogTitleTextAndLinkRange(
PasswordTittleType dialog_type,
base::string16* title,
gfx::Range* title_link_range) {
+ DCHECK(!password_manager::IsValidAndroidFacetURI(form_origin_url.spec()));
std::vector<size_t> offsets;
std::vector<base::string16> replacements;
int title_id = 0;
@@ -96,14 +97,7 @@ void GetSavePasswordDialogTitleTextAndLinkRange(
// Check whether the registry controlled domains for user-visible URL (i.e.
// the one seen in the omnibox) and the password form post-submit navigation
// URL differs or not.
- password_manager::FacetURI facet_uri =
- password_manager::FacetURI::FromPotentiallyInvalidSpec(
- form_origin_url.spec());
- if (facet_uri.IsValidAndroidFacetURI()) {
- title_id = IDS_SAVE_PASSWORD_TITLE;
- replacements.push_back(
- base::ASCIIToUTF16(GetHumanReadableOriginForAndroidUri(facet_uri)));
- } else if (!SameDomainOrHost(user_visible_url, form_origin_url)) {
+ if (!SameDomainOrHost(user_visible_url, form_origin_url)) {
title_id = IDS_SAVE_PASSWORD_TITLE;
// TODO(palmer): Look into passing real language prefs here, not "".
// crbug.com/498069.
@@ -130,17 +124,11 @@ void GetSavePasswordDialogTitleTextAndLinkRange(
void GetManagePasswordsDialogTitleText(const GURL& user_visible_url,
const GURL& password_origin_url,
base::string16* title) {
+ DCHECK(!password_manager::IsValidAndroidFacetURI(password_origin_url.spec()));
// Check whether the registry controlled domains for user-visible URL
// (i.e. the one seen in the omnibox) and the managed password origin URL
// differ or not.
- password_manager::FacetURI facet_uri =
- password_manager::FacetURI::FromPotentiallyInvalidSpec(
- password_origin_url.spec());
- if (facet_uri.IsValidAndroidFacetURI()) {
- *title = l10n_util::GetStringFUTF16(
- IDS_MANAGE_PASSWORDS_TITLE_DIFFERENT_DOMAIN,
- base::ASCIIToUTF16(GetHumanReadableOriginForAndroidUri(facet_uri)));
- } else if (!SameDomainOrHost(user_visible_url, password_origin_url)) {
+ if (!SameDomainOrHost(user_visible_url, password_origin_url)) {
// TODO(palmer): Look into passing real language prefs here, not "".
base::string16 formatted_url = url_formatter::FormatUrlForSecurityDisplay(
password_origin_url, std::string());

Powered by Google App Engine
This is Rietveld 408576698